Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Encrypt aws_iam_access_key.secret with pgp #10615

Merged
merged 1 commit into from
Dec 8, 2016

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Dec 8, 2016

Optionally encrypt the iam access key secret with a pgp key.

This is an alternative to #10450 where we forced users to supply a PGP Key, and was a breaking change.

Here we maintain the current behavior, but offer a pgp_key parameter to optionally encrypt the returned secret.

The upgrade UX becomes "nothing"; there is no diff or plan or change. Adding a pgp_key will result in a ForceNew plan.

optionally encrypt the iam access key secret with a pgp key
Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Awesome test case, too.

@mitchellh mitchellh merged commit 6d4f63c into master Dec 8, 2016
@mitchellh mitchellh deleted the b-aws-encrypt-access-key-secrets branch December 8, 2016 17:30
@mcanevet
Copy link
Contributor

@catsby @mitchellh secret is not set anymore with this patch. Would it be possible to have a deprecation period of one release before removing this feature so that code written for 0.7 still works in 0.8?

@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants