r/dpm_host_override: New resource #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is literally a copy/paste/search+replace of vsphere_drs_vm_override. It builds, but will not work in its current form.
Ie: Remove "default" from ha_vm_restart_priority and ha_vm_restart_timeout, ensuring that the expanders/flatteners can be re-used in the vsphere_ha_vm_override resource.
Resource CRUD is now done, will be working on tests and docs shortly.
One of the more interesting parts here is that this override needs to be an Edit operation instead of an Add operation for update, or else you get an invalid parameter fault.
resourceVSphereHaVMOverride is now resourceVSphereHAVMOverride, and its capitalized particle has been corrected in the same way. This is to make it consistent with other overrides.
Also added a missing cluster default for ha_vm_restart_timeout.
This contains the code, tests, and docs for the vsphere_dpm_host override resource, which allows one to override settings for a host within a vsphere_comptue_cluster resource.
vancluever
added
enhancement
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the code, tests, and docs for the
vsphere_dpm_hostoverride resource, which allows one to override settings for a host within avsphere_comptue_clusterresource.