Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/compute_cluster: New data source #492

Merged
merged 1 commit into from
Apr 26, 2018
Merged

Conversation

vancluever
Copy link
Contributor

This adds the vsphere_compute_cluster data source, which allows one to
look up an existing cluster.

It also closes a convenience gap in the provider which has been a point
of confusion since around 1.0, in that people looking to supply the
resource_pool_id for a virtual machine were confused in that they didn't
think they had a resource pool. This now allows someone to specify a
cluster directly, and then use the resource_pool_id attribute from this
data source as the input to vsphere_virtual_machine.

This adds the vsphere_compute_cluster data source, which allows one to
look up an existing cluster.

It also closes a convenience gap in the provider which has been a point
of confusion since around 1.0, in that people looking to supply the
resource_pool_id for a virtual machine were confused in that they didn't
think they had a resource pool. This now allows someone to specify a
cluster directly, and then use the resource_pool_id attribute from this
data source as the input to vsphere_virtual_machine.
@vancluever vancluever added enhancement Type: Enhancement new-data-source Feature: New Data Source labels Apr 26, 2018
@vancluever vancluever requested a review from a team April 26, 2018 16:29
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vancluever
Copy link
Contributor Author

Thanks @bill-rich!

@vancluever vancluever merged commit 52837e0 into master Apr 26, 2018
@vancluever vancluever deleted the f-compute-cluster-data-source branch April 26, 2018 17:17
@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Type: Enhancement new-data-source Feature: New Data Source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants