r/virtual_machine: Roll back all VM post-clone config operations #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all VM post-clone operations were being rolled back correctly. Several config-building operations (namely surrounding device management and property gathering) were not being sent through the rollback handler, hence were at risk for causing an irrecoverable state on error. In addition, the ID was being set too early. This fixes this by ensuring that *all* operations that produce errors that happen from the moment a VM clone is finished, to right before VM customization, are all sent through the rollback handler. ID setting has been moved as well to right before customization is done. This is the earliest place where the VM can be reasonably preserved and Terraform will not immedately fail upon refresh.
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all VM post-clone operations were being rolled back correctly.
Several config-building operations (namely surrounding device management
and property gathering) were not being sent through the rollback
handler, hence were at risk for causing an irrecoverable state on error.
In addition, the ID was being set too early.
This fixes this by ensuring that all operations that produce errors
that happen from the moment a VM clone is finished, to right before VM
customization, are all sent through the rollback handler.
ID setting has been moved as well to right before customization is done.
This is the earliest place where the VM can be reasonably preserved and
Terraform will not immedately fail upon refresh.