r/virtual_machine: Enforce storage vMotion restrictions #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For use in some VM tests - will probably be removed once we fix the disk naming issues.
This commit adds restrictions to storage vMotion: * Externally-attached disks cannot be migrated. * Disk names must match the standard vSphere naming convention based on the current name of the virtual machine. * Linked clones are blocked from being migrated at this time. The latter two restrictions will be lifted once #295 is fully realized and we are tracking disks via a label/UUID combination.
All of these restrictions will more than likely be removed or modified in some way. The external attachment restriction will be a challenge, but ultimately we want to try and control the lifecycle of that outside of the VM, and work to re-attach that disk somehow after the migration. How we go about that remains to be seen.
|
Test output pending. PS: This also vendors the null resource as we use it in one test example now to stabilize disk names. |
|
Tests pass: Tests specific to this PR: |
|
Hey @vancluever Is the externally attached disk migration limitation still present in the latest release? We're currently doing that via direct VMware API calls and would move to terraform solution if that is available. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds restrictions to storage vMotion:
the current name of the virtual machine.
The latter two restrictions will be lifted once #295 is fully realized
and we are tracking disks via a label/UUID combination.
Disk attachment migration is something I'd like for us to handle as well eventually, but exactly how that will be handled is a bit tricky as VM configuration needs to be updated as well pretty much at the same time. It might not be possible in the long run.