Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags: Add tagging support for datacenters #177

Merged
merged 2 commits into from
Sep 25, 2017
Merged

Conversation

vancluever
Copy link
Contributor

This update adds in the tagging support for datacenters. Just a few
minor modifications, nothing too serious, although this does now add the
Read function as tags on a datacenter (any object for that matter) are
modifiable in a non-destructive way.

@vancluever vancluever added the enhancement Type: Enhancement label Sep 24, 2017
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Lot's going on here but it looks really good.

@vancluever
Copy link
Contributor Author

Thanks @mbfrahry! Don't forget that there are a few other PRs before this one, I've just based the work on this one on them as they have functionality that I need, so once those are reviewed and merged this PR and subsequent ones will shrink quite a bit 🙂

This update adds in the tagging support for datacenters. Just a few
minor modifications, nothing too serious, although this does now add the
read function as tags on a datacenter (any object for that matter) are
modifiable in a non-destructive way.
@vancluever vancluever merged commit 2d81c4b into master Sep 25, 2017
@vancluever vancluever deleted the f-tag-datacenters branch September 25, 2017 22:25
@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants