Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new data source: vsphere_distributed_virtual_switch #170

Merged
merged 5 commits into from
Oct 11, 2017

Conversation

jorgenunez
Copy link
Contributor

New data source vsphere_distributed_virtual_switch. Required for future vsphere_distributed_virtual_portgroup in case that those aren't created with Terraform.

Depends on some helper code from #135

@ze42
Copy link

ze42 commented Sep 21, 2017

vsphere_distributed_virtual_portgroup will be usefull here.

Any ETA on some MR for those? (days, weeks, monthes?)

@jorgenunez
Copy link
Contributor Author

Hi @ze42, I have some PoC code for it and was planning to push it forward in the next couple of weeks unless someone from HC wants to take the lead and get it through a bit faster.

@vancluever
Copy link
Contributor

@ze42, echoing @jorgenunez's approximate roadmap here, right now we are working on tagging support but wrapping up the DVS stuff is a priority. This will probably get more attention next week.

@vancluever vancluever added enhancement Type: Enhancement new-resource Feature: New Resource labels Sep 23, 2017
@jvdbeemt
Copy link

We really would love the additional feature for vsphere_distributed_virtual_portgroup. Could we help and test your PoC code?

Caught this was running a more complex test of the DVS data source.
Quick fix that prevents a crash - and makes things correct of course.
 * Refactor for updates since PR was submitted.
 * Make datacenter optional if path is properly supplied (path lookup
 workflow is the same as the DVS resource import, where datacenter is
 not necessary either).
 * Add uplinks as an exported variable.
 * Add tests.
 * Update documentation.
@vancluever
Copy link
Contributor

Hey @jorgenunez! Thanks for this as well - I have made some updates to it to reflect the final state of the DVS resource and am merging it now. Good work on this!

@vancluever vancluever merged commit 7a53d56 into hashicorp:master Oct 11, 2017
@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Type: Enhancement new-resource Feature: New Resource
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants