Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Terraform Plugin Framework #155

Merged
merged 29 commits into from
Jan 11, 2023
Merged

Migrate to Terraform Plugin Framework #155

merged 29 commits into from
Jan 11, 2023

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Dec 13, 2022 •
edited
Loading

Closes #84
Closes #153
Closes #80

New release process integrating Changie automation depends on hashicorp/ghaction-terraform-provider-release#26

@SBGoods SBGoods requested a review from a team as a code owner December 13, 2022 20:33
bendbennett
bendbennett reviewed Dec 15, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments but overall looks great!
Nice job 👍

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
internal/localtypes/file_permission_type.go Outdated Show resolved Hide resolved
internal/localtypes/file_permission_type.go Outdated Show resolved Hide resolved
internal/provider/data_source_local_file.go Outdated Show resolved Hide resolved
internal/provider/data_source_local_sensitive_file.go Outdated Show resolved Hide resolved
internal/provider/data_source_local_sensitive_file.go Outdated Show resolved Hide resolved
internal/provider/resource_local_file.go Outdated Show resolved Hide resolved
bendbennett
bendbennett approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

bflad
bflad approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

internal/localtypes/file_permission_type.go Show resolved Hide resolved
internal/provider/resource_local_sensitive_file_test.go Outdated Show resolved Hide resolved
@SBGoods SBGoods merged commit 11c4189 into main Jan 11, 2023
@SBGoods SBGoods deleted the issue-84 branch January 11, 2023 15:32
@SBGoods SBGoods mentioned this pull request Jan 12, 2023
Closed
1 task
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
dependencies documentation size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Provider Migrate to terraform-plugin-framework Migrate Documentation to terraform-plugin-docs
3 participants
@SBGoods @bflad @bendbennett