Add hash outputs of file content #142

zachwhaley · 2022-09-09T15:39:30Z

Per #137 this brings the provider up to feature parity with all of Terraform's built-in file-reading functions

The following outputs are added to local_file, local_sensitive_file, data_local_file, and data_local_sensitive_file:

content_md5 - MD5 checksum of file content.
content_sha1 - SHA1 checksum of file content.
content_sha256 - SHA256 checksum of file content.
content_base64sha256 - Base64 encoded SHA256 checksum of file content.
content_sha512 - SHA512 checksum of file content.
content_base64sha512 - Base64 encoded SHA512 checksum of file content.

Closes #137

Closes hashicorp#137

bookshelfdave · 2022-10-28T19:34:08Z

(copied from hashicorp/terraform-provider-archive#165 (comment))

Hello @zachwhaley - my apologies for the delay in getting these reviewed. Our team synced up with the Terraform Core engineers and discussed this PR. As currently implemented, users will need to apply changes twice on updates before they are realized in downstream resources/outputs/etc.

This issue can be solved by using a CustomizeDiff, so the plan also sees the expected value changes, which in turn any references can also see those value changes at the same time.

However, both local and archive providers are scheduled to be migrated to the Terraform Plugin Framework this quarter, and we have a strong preference to implement this feature using attribute plan modifiers with the framework.

For now, we are going to hold off on bringing these changes in. Our plan is to reevaluate this once the migration to the plugin framework is complete.

bendbennett · 2022-10-31T07:23:29Z

@zachwhaley the issue for tracking migration to the Terraform Plugin Framework is #84

zachwhaley · 2023-01-11T16:30:37Z

@bendbennett I see that #84 has been closed 🎉

Is there another issue/PR to add the additional hash outputs that I can follow?

bendbennett · 2023-01-11T17:43:56Z

@zachwhaley 👋

Would you be happy to update this PR to use the latest changes in main for the additional hash outputs?

zachwhaley · 2023-01-13T16:15:43Z

@zachwhaley 👋

Would you be happy to update this PR to use the latest changes in main for the additional hash outputs?

I can take a look, but all of my changes have conflicts now so it may take me some time to work out the new way to do things. Y'all feel free to make the changes without me :)

…into shas

zachwhaley · 2023-01-13T17:26:56Z

@bendbennett I've pushed my first attempt at resolving the conflicts, although I'm not sure if I'm taking advantage of the (edit) attribute plan modifiers @bookshelfdave mentioned.

bendbennett · 2023-01-16T07:22:42Z

@zachwhaley thank you for updating the PR.

Could you run make generate to update the docs and commit the changes?

Will ask the team to review this shortly. Thanks again.

SBGoods

Thank you for your contribution! I left a few suggestions about changing the description for the id attribute to add clarity. After you make those changes, run make generate and commit it to Git so that those changes are reflected in the documentation.

Can you also add similar changes that you made to the tests in data_source_local_file_test to the other resources/data sources?

internal/provider/data_source_local_file.go

internal/provider/data_source_local_sensitive_file.go

internal/provider/resource_local_sensitive_file.go

internal/provider/resource_local_file.go

Co-authored-by: Selena Goods <[email protected]>

zachwhaley · 2023-02-07T15:49:48Z

@SBGoods Friendly poke :)

SBGoods

The implementation here looks good to me! Two things:

Can you add acceptance tests for the local_sensitive_file data source and both resources?
Can you add a Changelog entry for this change? Our CONTRIBUTING.md describes how to do this, but please let me know if the instructions are not clear. A potential changelog entry for this change can look like this under the FEATURES category:

provider: added support for MD5, SHA1, SHA256, and SHA512 checksum outputs.

As always, please reach out if there are any questions, Thank you!

zachwhaley · 2023-02-08T16:04:01Z

Can you add acceptance tests for the local_sensitive_file data source and both resources?

Yep 👍🏻

Can you add a Changelog entry for this change? Our CONTRIBUTING.md describes how to do this, but please let me know if the instructions are not clear. A potential changelog entry for this change can look like this under the FEATURES category:

That seems like something y'all would want to do as opposed to external contributors? Would I put the entry under 2.3? Or add a new 2.4 release? Ultimately, I'd feel more comfortable if y'all updated that file :)

…into shas

SBGoods

Looks good to me. Thanks again for the contribution!

bendbennett

LGTM 👍

zachwhaley · 2023-02-28T19:15:04Z

Hi! @bendbennett Don't mean to rush y'all, but I was wondering how often this provider ships a release? I tried looking at the repo's documentation but didn't find anything.

bookshelfdave · 2023-03-01T20:45:06Z

hi @zachwhaley - we don't have a defined cadence for releasing the utility providers. This release is queued behind a few other things, but it should be out in the next few weeks. My apologies for the delay!

SBGoods · 2023-03-08T15:51:54Z

@zachwhaley We just released v2.4.0 which includes this change. Thank you again for the contribution!

<Actions> <action id="433396668ffbe69847f17a09a6cf8e8e490b1f5912247cfc582e78aa0c952904"> <h3>Bump Terraform `local` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>"hashicorp/local" updated from "2.4.0" to "2.4.0" in file ".terraform.lock.hcl"</p> <details> <summary>2.4.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-local/releases/tag/v2.4.0
NOTES:

* This Go module has been updated to Go 1.19 per the [Go support policy](https://golang.org/doc/devel/release.html#policy). Any consumers building on earlier Go versions may experience errors. ([#184](https://github.com/hashicorp/terraform-provider-local/issues/184))

FEATURES:

* resource/local_file: added support for `MD5`, `SHA1`, `SHA256`, and `SHA512` checksum outputs. ([#142](hashicorp/terraform-provider-local#142 resource/local_sensitive_file: added support for `MD5`, `SHA1`, `SHA256`, and `SHA512` checksum outputs. ([#142](hashicorp/terraform-provider-local#142 data-source/local_file: added support for `MD5`, `SHA1`, `SHA256`, and `SHA512` checksum outputs. ([#142](hashicorp/terraform-provider-local#142 data-source/local_sensitive-file: added support for `MD5`, `SHA1`, `SHA256`, and `SHA512` checksum outputs. ([#142](https://github.com/hashicorp/terraform-provider-local/issues/142))


</pre> </details> </details> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>

github-actions · 2024-05-25T07:10:47Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Add more hash outputs of file content

dba7d8d

Closes hashicorp#137

github-actions bot added the size/M label Sep 9, 2022

zachwhaley mentioned this pull request Sep 9, 2022

Feature parity with all of Terraform's built-in file-reading functions #137

Closed

1 task

Add hash outputs to resource

b898e37

zachwhaley changed the title ~~Add more hash outputs of file content~~ Add hash outputs of file content Sep 9, 2022

github-actions bot added size/L and removed size/M labels Sep 9, 2022

zachwhaley marked this pull request as ready for review September 9, 2022 18:40

zachwhaley requested a review from a team as a code owner September 9, 2022 18:40

Incapsulate Sum functions inside function

ea7a773

tristanmorgan mentioned this pull request Sep 13, 2022

Output property of generated file for local_file resource #140

Closed

1 task

update docs

58c70ca

github-actions bot added the documentation label Sep 14, 2022

Use actual values in testing instead of generating values

9898b3a

Merge branch 'main' of github.com:hashicorp/terraform-provider-local …

b56fb17

…into shas

github-actions bot removed the documentation label Jan 13, 2023

generate docs

ff88357

SBGoods reviewed Jan 26, 2023

View reviewed changes

zachwhaley and others added 5 commits January 27, 2023 08:20

Apply suggestions from code review

ef5261a

Co-authored-by: Selena Goods <[email protected]>

Review suggestion

b7cb1f0

generate docs

3a0c45b

Remove hashes from resource_local_file.Read function

db94aa1

declare empty struct with var

a7e61f9

forgot period

3677dc3

SBGoods reviewed Feb 7, 2023

View reviewed changes

add missing tests

7e7d461

zachwhaley and others added 3 commits February 8, 2023 14:21

Merge branch 'main' of github.com:hashicorp/terraform-provider-local …

48c2374

…into shas

Fix lint error

5d559cf

Add Changelog entries

4a605b9

SBGoods approved these changes Feb 9, 2023

View reviewed changes

bendbennett reviewed Feb 9, 2023

View reviewed changes

SBGoods merged commit 1c122b1 into hashicorp:main Feb 9, 2023

zachwhaley deleted the shas branch February 9, 2023 23:32

github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add hash outputs of file content #142

Add hash outputs of file content #142

zachwhaley commented Sep 9, 2022 •

edited

Loading

bookshelfdave commented Oct 28, 2022

bendbennett commented Oct 31, 2022

zachwhaley commented Jan 11, 2023

bendbennett commented Jan 11, 2023

zachwhaley commented Jan 13, 2023

zachwhaley commented Jan 13, 2023 •

edited

Loading

bendbennett commented Jan 16, 2023 •

edited

Loading

SBGoods left a comment

zachwhaley commented Feb 7, 2023

SBGoods left a comment

zachwhaley commented Feb 8, 2023

SBGoods left a comment

bendbennett left a comment

zachwhaley commented Feb 28, 2023

bookshelfdave commented Mar 1, 2023

SBGoods commented Mar 8, 2023

github-actions bot commented May 25, 2024

Add hash outputs of file content #142

Add hash outputs of file content #142

Conversation

zachwhaley commented Sep 9, 2022 • edited Loading

bookshelfdave commented Oct 28, 2022

bendbennett commented Oct 31, 2022

zachwhaley commented Jan 11, 2023

bendbennett commented Jan 11, 2023

zachwhaley commented Jan 13, 2023

zachwhaley commented Jan 13, 2023 • edited Loading

bendbennett commented Jan 16, 2023 • edited Loading

SBGoods left a comment

Choose a reason for hiding this comment

zachwhaley commented Feb 7, 2023

SBGoods left a comment

Choose a reason for hiding this comment

zachwhaley commented Feb 8, 2023

SBGoods left a comment

Choose a reason for hiding this comment

bendbennett left a comment

Choose a reason for hiding this comment

zachwhaley commented Feb 28, 2023

bookshelfdave commented Mar 1, 2023

SBGoods commented Mar 8, 2023

github-actions bot commented May 25, 2024

zachwhaley commented Sep 9, 2022 •

edited

Loading

zachwhaley commented Jan 13, 2023 •

edited

Loading

bendbennett commented Jan 16, 2023 •

edited

Loading