-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubernetes_ingress_v1 timeouts #1936
Conversation
0059557
to
e6c50a2
Compare
@arybolovlev Please could you elaborate on why there is a binding to port 80 inside the ingress test (wait for load balancer)? This port requires root privileges while the container runs without it. I had to change it to something greater than 1024 to make the test pass. |
Great catch! This is a very good question and unfortunately I don't know the reason for that. What would you say if we use It would be great if you can add this as well in addition to the great job you have already done. 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, just one more query from my end.
Could you please add a changelog file so we can then auto-generate change log for the upcoming release?
It will be a simple text file in .changelog
folder. Like this: .changelog/1936.txt
. With the following content:
```release-note:enhancement
`resource/kubernetes_ingress_v1`: add create and delete timeouts
```
Thank you! 👍🏻
@arybolovlev Addressed all your concerns. Please let me know if there's anything else you can think of. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Tensho!
🚀
Looks great! I will go ahead and merge your changes. They will be available in the upcoming release. Please keep an eye on the release notes!
Happy New Year! 🎉
Thank you for your guidance and quick response, @arybolovlev 🙇 Keeping an eye on releases. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
The
kubernetes_ingress_v1
resource has timeouts support, but it's not specified in resource schema definition and not reflected in the documentation.Release Note
Test Outpus
Run basic test against kind cluster:
Run wait for load balancer test against GKE cluster:
References
Community Note