-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow generate_name
on cluster roles + bindings, and role bindings
#1899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @multani,
Thank you for your contribution! All looks great 👍🏻, just one small request from my end.
Could you please add a changelog file so we can then auto-generate a change log for the upcoming release?
It will be a simple text file in .changelog
folder. Like this: .changelog/1899.txt
. With the following content:
```release-note:enhancement
`resource/kubernetes_cluster_role`: add attribute `generate_name` to produce a unique random name
```
```release-note:enhancement
`resource/kubernetes_cluster_role_v1`: add attribute `generate_name` to produce a unique random name
```
```release-note:enhancement
`resource/kubernetes_cluster_role_binding`: add attribute `generate_name` to produce a unique random name
```
```release-note:enhancement
`resource/kubernetes_cluster_role_binding_v1`: add attribute `generate_name` to produce a unique random name
```
```release-note:enhancement
`resource/kubernetes_role_binding`: add attribute `generate_name` to produce a unique random name
```
```release-note:enhancement
`resource/kubernetes_role_binding_v1`: add attribute `generate_name` to produce a unique random name
```
Thank you! 🙏
Hi @arybolovlev , I just added the changelog file now 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! 👍🏻 Thank you and congratulations on the first-time contribution! 🎉
Your changes will be available in the upcoming release. Please keep an eye on the release notes.
Happy New Year! 🎉
Thanks for the merge @arybolovlev, this will be an excellent New Year's release! 🙇 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Fix #588
Community Note