-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TK-1897] Fix behavior
attribute of kubernetes_horizontal_pod_autoscaler_v2(beta2)
#1853
Conversation
81ddc37
to
1e5336a
Compare
Type: schema.TypeList, | ||
Description: "Behavior configures the scaling behavior of the target in both Up and Down directions (`scale_up` and `scale_down` fields respectively).", | ||
Optional: true, | ||
Computed: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made spec.behavior
computed. But since I also moved the whole spec
into a diff file\function it is not clear what has changed.
Type: schema.TypeList, | ||
Description: "Scaling policy for scaling Up", | ||
Optional: true, | ||
Computed: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made spec.behavior.scale_up
computed. But since I also moved the whole spec
into a diff file\function it is not clear what has changed.
Type: schema.TypeList, | ||
Description: "Scaling policy for scaling Down", | ||
Optional: true, | ||
Computed: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made spec.behavior.scale_down
computed. But since I also moved the whole spec
into a diff file\function it is not clear what has changed.
1e5336a
to
9ff4ef0
Compare
f0213f6
to
88c793f
Compare
4fc44a0
to
0535275
Compare
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
When the attributes
spec.behavior
,spec.behavior.scale_up
andspec.behavior.scale_down
of the resourceskubernetes_horizontal_pod_autoscaler_v2
andkubernetes_horizontal_pod_autoscaler_v2beta2
are not set, the defaultHPAScalingRules
for scale up and scale down are used. This PR makes them computed and thus it won't cause drifts on plan/apply when the attributes are not set.Additional changes:
schema_horizontal_pod_autoscaler.go
since it is used multiple times in different placesAcceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Fix: #1850
Community Note