Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/kubernetes_persistent_volume: Mark persistent_volume_source as ForceNew on 1.9+ #139

Merged
merged 2 commits into from
Mar 23, 2018
Merged

resource/kubernetes_persistent_volume: Mark persistent_volume_source as ForceNew on 1.9+ #139

merged 2 commits into from
Mar 23, 2018

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Mar 5, 2018 •
edited
Loading

This is to address the following test failures on 1.9:

=== RUN   TestAccKubernetesPersistentVolume_googleCloud_basic
--- FAIL: TestAccKubernetesPersistentVolume_googleCloud_basic (24.08s)
    testing.go:513: Step 1 error: Error applying: 1 error(s) occurred:
        
        * kubernetes_persistent_volume.test: 1 error(s) occurred:
        
        * kubernetes_persistent_volume.test: PersistentVolume "tf-acc-test-abpo9v9rgq" is invalid: spec.persistentvolumesource: Forbidden: is immutable after creation
FAIL

Test results

screen shot 2018-03-20 at 11 53 28

screen shot 2018-03-20 at 11 54 11

screen shot 2018-03-20 at 11 53 51

screen shot 2018-03-22 at 10 13 36

@radeksimko radeksimko mentioned this pull request Mar 18, 2018
Merged
@radeksimko radeksimko force-pushed the b-pvs-forcenew-19 branch 2 times, most recently from 4af3121 to bc56de7 Compare March 18, 2018 12:47
@radeksimko radeksimko changed the title [WIP] resource/kubernetes_persistent_volume: Mark persistent_volume_source as ForceNew on 1.9+ resource/kubernetes_persistent_volume: Mark persistent_volume_source as ForceNew on 1.9+ Mar 20, 2018
@radeksimko radeksimko requested a review from a team March 20, 2018 11:55
@radeksimko radeksimko merged commit 0eef610 into master Mar 23, 2018
@radeksimko radeksimko deleted the b-pvs-forcenew-19 branch March 23, 2018 06:44
@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @paddycarver