Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes_persistent_volume to support arg secret_namespace for azure_file volume type #1160

Closed
ortelli-oxalide opened this issue Feb 10, 2021 · 2 comments · Fixed by #1204
Labels
enhancement help wanted theme/coverage issues that involve improving API coverage for the provider

Comments

@ortelli-oxalide
Copy link

Description

Resource kubernetes_persistent_volume should expose secret_namespace argument for azure_file volume type, consistently with k8s api

Empirically, this feature become almost necessary with AKS/K8S version 1.19. When spec.azureFile.secretNamespace is not specified, with version 1.18 pods would lookup for azure file secret in their own namespace, with version 1.19 they look that up in the default namespace.

Potential Terraform Configuration

resource "kubernetes_persistent_volume" "data" {
  metadata {
    name = "my-data-pv"
  }
  spec {
    capacity = {
      storage = "100Gi"
    }
    access_modes       = ["ReadWriteMany"]
    storage_class_name = "azurefile"

    persistent_volume_source {
      azure_file {
        secret_namespace = "my-namespace"  # Here is the argument yet to be supported in TF provider
        secret_name      =  "bla"
        share_name       =  "blabla"
        read_only        = "false"
      }
    }

    mount_options = [
      ...
    ]
  }
}

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@alexsomesan alexsomesan added help wanted theme/coverage issues that involve improving API coverage for the provider labels Feb 24, 2021
@bancek
Copy link
Contributor

bancek commented Mar 17, 2021

I also need this because we've upgraded our AKS to 1.19 and the persistent volume stopped working. As a workaround we've moved our secret to the default namespace but we'd like to have this done properly by setting the secret_namespace.

I've opened a PR #1204

@ghost
Copy link

ghost commented Apr 29, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement help wanted theme/coverage issues that involve improving API coverage for the provider
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants