From d5470aa6690dd8d2563f9acd8614ac1157096328 Mon Sep 17 00:00:00 2001 From: Dana Hoffman Date: Fri, 8 Nov 2019 22:51:41 +0000 Subject: [PATCH] allow setting autoscaler min_replicas to 0 Signed-off-by: Modular Magician --- google/resource_compute_autoscaler.go | 2 +- google/resource_compute_autoscaler_test.go | 2 +- google/resource_compute_region_autoscaler.go | 2 +- google/resource_compute_region_autoscaler_test.go | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/google/resource_compute_autoscaler.go b/google/resource_compute_autoscaler.go index 09490fec0c1..0255572e2c8 100644 --- a/google/resource_compute_autoscaler.go +++ b/google/resource_compute_autoscaler.go @@ -572,7 +572,7 @@ func expandComputeAutoscalerAutoscalingPolicy(v interface{}, d TerraformResource transformedMinReplicas, err := expandComputeAutoscalerAutoscalingPolicyMinReplicas(original["min_replicas"], d, config) if err != nil { return nil, err - } else if val := reflect.ValueOf(transformedMinReplicas); val.IsValid() && !isEmptyValue(val) { + } else { transformed["minNumReplicas"] = transformedMinReplicas } diff --git a/google/resource_compute_autoscaler_test.go b/google/resource_compute_autoscaler_test.go index 4c8a89b46c2..e41f5f1aa94 100644 --- a/google/resource_compute_autoscaler_test.go +++ b/google/resource_compute_autoscaler_test.go @@ -141,7 +141,7 @@ resource "google_compute_autoscaler" "foobar" { target = "${google_compute_instance_group_manager.foobar.self_link}" autoscaling_policy { max_replicas = 10 - min_replicas = 1 + min_replicas = 0 cooldown_period = 60 cpu_utilization { target = 0.5 diff --git a/google/resource_compute_region_autoscaler.go b/google/resource_compute_region_autoscaler.go index 85af09071f8..6fe7b8ce1ee 100644 --- a/google/resource_compute_region_autoscaler.go +++ b/google/resource_compute_region_autoscaler.go @@ -569,7 +569,7 @@ func expandComputeRegionAutoscalerAutoscalingPolicy(v interface{}, d TerraformRe transformedMinReplicas, err := expandComputeRegionAutoscalerAutoscalingPolicyMinReplicas(original["min_replicas"], d, config) if err != nil { return nil, err - } else if val := reflect.ValueOf(transformedMinReplicas); val.IsValid() && !isEmptyValue(val) { + } else { transformed["minNumReplicas"] = transformedMinReplicas } diff --git a/google/resource_compute_region_autoscaler_test.go b/google/resource_compute_region_autoscaler_test.go index 719d2be0e13..221820681d9 100644 --- a/google/resource_compute_region_autoscaler_test.go +++ b/google/resource_compute_region_autoscaler_test.go @@ -89,7 +89,7 @@ resource "google_compute_region_autoscaler" "foobar" { target = "${google_compute_region_instance_group_manager.foobar.self_link}" autoscaling_policy { max_replicas = 5 - min_replicas = 1 + min_replicas = 0 cooldown_period = 60 cpu_utilization { target = 0.5