Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for network_config to google_container_node_pool #8738

Closed
rileykarson opened this issue Mar 19, 2021 · 4 comments · Fixed by GoogleCloudPlatform/magic-modules#4790, hashicorp/terraform-provider-google-beta#3472 or #9707

Comments

@rileykarson
Copy link
Collaborator

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

We'll also want it supported in google_container_cluster where node pools are inlined (the default pool, inline node pool list)

New or Affected Resource(s)

  • google_container_node_pool
  • google_container_cluster

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.

References

  • b/178640055
@upodroid
Copy link
Contributor

I think we can close this. I added ILB Subsetting a while back in GoogleCloudPlatform/magic-modules#4626 and the other fields are already available.

https://pkg.go.dev/google.golang.org/api/container/v1beta1#NetworkConfig

enable_intranode_visibility - (Optional) Whether Intra-node visibility is enabled for this cluster. This makes same node pod to pod traffic visible for VPC network.

enable_l4_ilb_subsetting - (Optional, Beta) Whether L4ILB Subsetting is enabled for this cluster.

private_ipv6_google_access - (Optional) The desired state of IPv6 connectivity to Google Services. By default, no private IPv6 access to or from Google Services (all access will be via IPv4).

datapath_provider - (Optional) The desired datapath provider for this cluster. By default, uses the IPTables-based kube-proxy implementation.

default_snat_status - (Optional) GKE SNAT DefaultSnatStatus contains the desired state of whether default sNAT should be disabled on the cluster, API doc.

GKE has many breaking changes planned for v4. We might as well make NetworkConfig parameters nested as well to make it lineup with the API format.

@rileykarson
Copy link
Collaborator Author

This refers to the very similarly named https://pkg.go.dev/google.golang.org/api/container/v1beta1#NodeNetworkConfig block at the node pool level, not that cluster-level one!

@upodroid
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2021
@github-actions github-actions bot added service/container forward/review In review; remove label to forward labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.