Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout when creating subnetworks #718

Closed
eilgin opened this issue Nov 10, 2017 · 8 comments · Fixed by #871
Closed

Timeout when creating subnetworks #718

eilgin opened this issue Nov 10, 2017 · 8 comments · Fixed by #871
Labels

Comments

@eilgin
Copy link
Contributor

eilgin commented Nov 10, 2017

Terraform Version

terraform -v
Terraform v0.10.8

Affected Resource(s)

Please list the resources as a list, for example:

  • google_compute_subnetwork

Terraform Configuration Files

resource "google_compute_subnetwork" "default_europe_west" {
  count   = 3
  name    = "${var.name}-subnet-${count.index + 1}"
  project = "${google_project.default.id}"

  ip_cidr_range = "10.132.${count.index + 1}.0/16"

  network                  = "${google_compute_network.default.self_link}"
  region                   = "europe-west${count.index + 1}"
  private_ip_google_access = true

  lifecycle {
    create_before_destroy = true
  }
}

Debug Output

Please provider a link to a GitHub Gist containing the complete debug output: https://www.terraform.io/docs/internals/debugging.html. Please do NOT paste the debug output in the issue; just paste a link to the Gist.

Expected Behavior

module.foo.module.project.google_compute_subnetwork.default_europe_west[0]: Creation complete after XXs (ID: foo)

Actual Behavior

The subnetworks takes too much time to spawn and it reaches the timeout limit (i guess it's 4 minutes):

* module.foo.module.project.google_compute_subnetwork.default_europe_west[0]: 1 error(s) occurred:

* google_compute_subnetwork.default_europe_west.0: Error waiting for Creating Subnetwork: timeout while waiting for state to become 'DONE' (last state: 'RUNNING', timeout: 4m0s)

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

  1. terraform plan -out=tfplan
  2. terraform apply tfplan
@rosbo
Copy link
Contributor

rosbo commented Nov 20, 2017

@eilgin Were you planning on working on this? If not, I am happy to take it.

@rosbo rosbo added the easy label Nov 20, 2017
@johnraz
Copy link
Contributor

johnraz commented Dec 15, 2017

@rosbo @eilgin may I ask what the state of this is? Is someone working on this yet?

I'm not used to Go but if you think it's easy enough and maybe can provide me with some guidance on where to look at this I would gladly submit a PR because this is annoying me like crazy 😄

@eilgin
Copy link
Contributor Author

eilgin commented Dec 15, 2017

@johnraz i'll let @rosbo take this since he said that he'd gladly take it 😄

@johnraz
Copy link
Contributor

johnraz commented Dec 15, 2017

And I would love to start contributing too, just FTR ;-)

@rosbo
Copy link
Contributor

rosbo commented Dec 15, 2017

Hi Jonathan,

I am glad you want to start contributing to this project :)

The best way to solve this issue is to add configurable timeout support for the google_compute_subnetwork resource. I implemented something similar for the google_compute_instance. You can look at that PR #856 for inspiration (in fact, it should be pretty similar).

Let me know if you need any help.

Thank you

@johnraz
Copy link
Contributor

johnraz commented Dec 16, 2017

@rosbo awesome, thanks for the warm welcome.

I'll try to do this in the best way possible and will submit a PR as soon as I get it done.

Cheers.

@johnraz
Copy link
Contributor

johnraz commented Dec 16, 2017

@rosbo @eilgin ☝️ there is the PR 🎉

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants