Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_os_login_ssh_public_key : Update of key value should recreate resource #6399

Closed
dinwath opened this issue May 17, 2020 · 2 comments · Fixed by GoogleCloudPlatform/magic-modules#3543, #6433 or hashicorp/terraform-provider-google-beta#2094
Assignees
Labels

Comments

@dinwath
Copy link

dinwath commented May 17, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v0.12.24

  • provider.google v3.21.0
  • provider.tls v2.1.1

Affected Resource(s)

  • google/resource_os_login_ssh_public_key.go

Terraform Configuration Files

locals {
  settings = yamldecode(file("./local_settings.yml"))
}

provider "google" {
  credentials = file(local.settings.creds)
  project     = local.settings.project
  region      = local.settings.region
  zone        = local.settings.zone
}

data "google_client_openid_userinfo" "terraform_service_account" {}

resource "tls_private_key" "ephemeral" {
  rsa_bits  = 2048
  algorithm = "RSA"
}

resource "google_os_login_ssh_public_key" "service_account_key" {
  user = data.google_client_openid_userinfo.terraform_service_account.email
  key  = tls_private_key.ephemeral.public_key_openssh
}

Debug Output

Panic Output

Expected Behavior

Changing the public key fingerprint should have marked the google_os_login_ssh_public_key resource for complete substitution

Actual Behavior

google_os_login_ssh_public_key is simply marked for in-place update, and upon second apply an error message is raised:

Error: Provider produced inconsistent result after apply

When applying changes to google_os_login_ssh_public_key.service_account_key,
provider "registry.terraform.io/-/google" produced an unexpected new value for
was present, but now absent.

This is a bug in the provider, which should be reported in the provider's own
issue tracker.

Steps to Reproduce

  1. terraform apply
  2. terraform taint tls_private_key.ephemeral
  3. terraform apply

Important Factoids

References

  • #0000
@ghost ghost added the bug label May 17, 2020
@venkykuberan venkykuberan self-assigned this May 18, 2020
@venkykuberan
Copy link
Contributor

Yes, it should recreate the resource. Thanks for filing the issue, I will move this to code change bucket.

@ghost
Copy link

ghost commented Jun 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.