Support for node pool surge upgrades

[gillesdouaire]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Google has introduced a new feature for nodepool upgrades - it's called "surge upgrade".

New or Affected Resource(s)

• google_container_node_pool

Potential Terraform Configuration

This feature is controlled by two distinct parameters, and there should be provision to support these:

• max-surge-upgrade
• max-unavailable-upgrade

References

Feature is described here: https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-upgrades#surge

[Stono]

This is already available on instance group templates:

      + update_policy {
          + max_surge_fixed       = 0
          + max_unavailable_fixed = 1
          + min_ready_sec         = 0
          + minimal_action        = "REPLACE"
          + type                  = "PROACTIVE"
        }

So probably best to follow the same structure?

[chrissng]

@Stono the google_container_node_pool underlying GKE Beta API specifies only two settings: https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1beta1/UpgradeSettings

PR addressing this issue is here: GoogleCloudPlatform/magic-modules#2669

[danawillow]

GoogleCloudPlatform/magic-modules#2669 was merged today and should be available in 3.1.0.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!