Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GITHUB_ORGANIZATION environment variable for Cloudbuild GitHub owner #4629

Closed
orinokai opened this issue Oct 8, 2019 · 2 comments
Closed

Comments

@orinokai
Copy link

orinokai commented Oct 8, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

When using GitHub repositories with google_cloudbuild_trigger it would be useful to optionally source the owner property from the GITHUB_ORGANIZATION environment variable.

I currently use this env var with the GitHub provider and it's useful to avoid hardcoding the owner or passing it as a variable. It is specifically useful when writing generic modules that could be used by any GitHub organisation, e.g. for publishing in the Terraform Registry.

New or Affected Resource(s)

  • google_cloudbuild_trigger

Potential Terraform Configuration

resource "google_cloudbuild_trigger" "dev" {
  project = "my-project"
  description = "Push to master branch"
  filename = "cloudbuild.yml"

  github {
#  owner = "my-organisation" <-- no longer necessary
    name  = var.name

    push {
      branch = "^master$"
    }
  }
}

References

@rileykarson
Copy link
Collaborator

rileykarson commented Apr 24, 2023

This can be solved with environment variables & input values by the user: https://developer.hashicorp.com/terraform/language/values/variables#environment-variables

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants