google_dns_managed_zone not importing visibility parameter, or honouring it

[jonwest]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment
• If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

Terraform v0.11.13

• provider.google v2.5.0

Affected Resource(s)

• google_dns_managed_zone

Terraform Configuration Files

resource "google_dns_managed_zone" "cheezewizards-com" {
  name     = "cheezewizards-com"
  dns_name = "cheezewizards.com."
  visibility = "public"
}

Debug Output

https://gist.github.com/jonwest/397a76397d2cdc96261d63b658900869

Panic Output

Expected Behavior

• Terraform would import resource and not require any changes

Actual Behavior

• Terraform wants to delete and recreate a DNS zone, which can't complete because (live!) records exist within the zone

Terraform will perform the following actions:

-/+ google_dns_managed_zone.cheezewizards-com (new resource required)
      id:             "cheezewizards-com" => <computed> (forces new resource)
      description:    "Managed by Terraform" => "Managed by Terraform"
      dns_name:       "cheezewizards.com." => "cheezewizards.com."
      name:           "cheezewizards-com" => "cheezewizards-com"
      name_servers.#: "4" => <computed>
      project:        "cheeze-wizards" => <computed>
      visibility:     "" => "public" (forces new resource)

Steps to Reproduce

1. Have a gcp_dns_managed_zone before 2.5.0 provider version without visibility parameter
2. Try to update anything related to DNS, new resource required pops up
3. Try to remove state and reimport to pull in Google's default "public" parameter
4. Adjust configuration to match visibility = "public"
5. terraform plan

Important Factoids

References

• Add support for private visibility to DNS managed zones #870

[jonwest]

Didn't see closed, related issue here #3435

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!