Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting boot disk size on preemptable dataproc nodes forces recreate when number of preemptable instances is 0 #2861

Closed
schaffino opened this issue Jan 11, 2019 · 2 comments · Fixed by GoogleCloudPlatform/magic-modules#3375, #6123 or hashicorp/terraform-provider-google-beta#1954
Assignees
Labels
bug forward/review In review; remove label to forward service/dataproc

Comments

@schaffino
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

Terraform v0.11.7

  • provider.google v1.19.0

Affected Resource(s)

google_dataproc_cluster

Terraform Configuration Files

resource "google_dataproc_cluster" "dataproc-cluster" {

  name   = "test"
  region = "europe-west1"

  cluster_config {

    gce_cluster_config {
      zone = "europe-west1-d"
    }

    master_config {
      num_instances = "1"
      machine_type  = "n1-standard-4"
      disk_config {
        boot_disk_size_gb = "500"
      }
    }

    worker_config {
      num_instances = "2"
      machine_type  = "n1-standard-4"

      disk_config {
        boot_disk_size_gb = "500"
      }
    }

    preemptible_worker_config {
     num_instances     = "0"
      disk_config {
        boot_disk_size_gb = "500"
      }
    }
  }
}

Debug Output

Panic Output

Expected Behavior

The terraform apply operation should return successfully without altering infrastructure

Actual Behavior

The cluster is destroyed and recreated

Plan shows

cluster_config.0.preemptible_worker_config.0.disk_config.0.boot_disk_size_gb: "" => "500" (forces new resource)

Steps to Reproduce

Run terraform apply twice in a row with the given config

Important Factoids

If the cluster has 1 or more preemptable instances then the problem does not occur. If the cluster is created with 1 or more preemptable instances but is scaled down to 0 instances outside terraform the problem will occur on the next run.

References

@ghost ghost added the bug label Jan 11, 2019
@emilymye emilymye assigned emilymye and unassigned emilymye Jan 14, 2019
@edwardmedia edwardmedia self-assigned this Apr 8, 2020
@edwardmedia
Copy link
Contributor

Using above code, I can repro the issue. my provider is v3.16.0

@ghost
Copy link

ghost commented May 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 16, 2020
@github-actions github-actions bot added service/dataproc forward/review In review; remove label to forward labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.