Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transient error: google_project.project: Error retrieving App Engine application ... 503 #2814

Closed
drigz opened this issue Jan 7, 2019 · 6 comments

Comments

@drigz
Copy link
Contributor

drigz commented Jan 7, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

terraform v0.11.7

  • provider.google: version = "~> 1.20"

Affected Resource(s)

  • google_project

Terraform Configuration Files

omitted, issue only occurs in our CI job

Debug Output

omitted, issue only occurs in our CI job

Panic Output

omitted, issue only occurs in our CI job

Expected Behavior

Terraform should not fail due to a transient 503 error.

Actual Behavior

Terraform occasionally fails with:

Error: Error refreshing state: 1 error(s) occurred:

* google_project.project: 1 error(s) occurred:

* google_project.project: google_project.project: Error retrieving App Engine application "my-project": googleapi: Error 503: The service is currently unavailable., backendError

Steps to Reproduce

omitted, issue only occurs in our CI job

Important Factoids

omitted, issue only occurs in our CI job

References

Should Apps.Get (call site) be wrapped with retryTime? I've made a similar PR before (https://github.com/terraform-providers/terraform-provider-google/pull/1713/files) but since the Apps.Get call has been removed in master/2.0.0 (#2386), I can't see if/how to make this change.

@ghost ghost added the bug label Jan 7, 2019
@emilymye
Copy link
Contributor

emilymye commented Jan 7, 2019

We now generate the app engines resource code in Magic Modules, the file would be here: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/third_party/terraform/resources/resource_app_engine_application.go

@emilymye emilymye added enhancement and removed bug labels Jan 7, 2019
@drigz
Copy link
Contributor Author

drigz commented Jan 8, 2019

@emilymye Thanks for the info! Will Apps.Get still be used by google_project in future 1.x releases? See resource_google_project.go#[email protected]. That code was removed from master by #2386 on Nov 2, but was still present in the v1.20.0 release on Dec 14.

@emilymye
Copy link
Contributor

emilymye commented Jan 8, 2019

Yup, that's the plan. @chrisst may have dealt with those retries for 2.x going forward but tagging to make sure.

@chrisst
Copy link
Contributor

chrisst commented Jan 8, 2019

Correct, as of https://github.com/terraform-providers/terraform-provider-google/pull/2568/files we should retry on 503's for all CRUD requests made by generated resources.

@danawillow
Copy link
Contributor

Closing due to @chrisst's comment, feel free to reopen if the issue is still occurring.

@ghost
Copy link

ghost commented Jun 14, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants