Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test(s): TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule #19086

Closed

Comments

@melinath
Copy link
Collaborator

melinath commented Aug 9, 2024

Impacted tests

  • TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule

Affected Resource(s)

  • google_scc_management_organization_event_threat_detection_custom_module

Failure rates

  • 27% (17 failed out of last 61 runs) as of 2024-08-09

Message(s)

Error: Error creating OrganizationEventThreatDetectionCustomModule: googleapi: Error 409: failed to create module due to concurrent modification

Possibly this indicates a need for a mutex and/or serializing these tests.

Nightly build test history

b/358692342

@ScottSuarez
Copy link
Collaborator

Still seeing failures here
https://hashicorp.teamcity.com/test/-224300369035462042?currentProjectId=TerraformProviders_GoogleCloud_GOOGLE_BETA_NIGHTLYTESTS&expandTestHistoryChartSection=true

=== RUN   TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule
=== PAUSE TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule
=== CONT  TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule
    vcr_utils.go:152: Step 1/4 error: Error running apply: exit status 1
        Error: Error creating OrganizationEventThreatDetectionCustomModule: googleapi: Error 409: failed to create module due to concurrent modification
          with google_scc_management_organization_event_threat_detection_custom_module.example,
          on terraform_plugin_test.tf line 2, in resource "google_scc_management_organization_event_threat_detection_custom_module" "example":
           2: resource "google_scc_management_organization_event_threat_detection_custom_module" "example" {
--- FAIL: TestAccSecurityCenterManagementOrganizationEventThreatDetectionCustomModule (6.35s)
FAIL

I suspect that since this runs in GA and BETA but is an ORG level test this is where the concurrent modification fails out? We should likely only run this test in one environment (if that is the problem).

@ScottSuarez ScottSuarez reopened this Aug 22, 2024
@ScottSuarez
Copy link
Collaborator

Actually.. I'm going to continue to keep a pulse on this. Since the change has only been checked in recently I'll let this play out a bit more.

@ScottSuarez ScottSuarez self-assigned this Aug 22, 2024
@ScottSuarez ScottSuarez removed their assignment Sep 5, 2024
@ScottSuarez
Copy link
Collaborator

Another failure today, un-assigning myself

@zli82016
Copy link
Collaborator

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.