Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Composer resource #1588

Closed
davispolly opened this issue Jun 4, 2018 · 13 comments
Closed

Cloud Composer resource #1588

davispolly opened this issue Jun 4, 2018 · 13 comments

Comments

@davispolly
Copy link

Cloud composer(https://cloud.google.com/composer/) which is Beta, currently does not have a terraform resource and few customers that I work with are requesting for it, so that they can provision it as IAAC.

@lawrenae
Copy link
Contributor

Is anyone taking a crack at this? I'd be interested in helping, and otherwise creating a PR for it. Thoughts?

@danawillow
Copy link
Contributor

Hey @lawrenae, at this point we're mostly trying to do new resource types with Magic Modules (https://github.com/GoogleCloudPlatform/magic-modules), that way we don't have to do extra work to add or review something that we know is going to be replaced soon.

If this is a thing you absolutely need right now and it's super important, I'd review a PR for it, but if you can wait a bit, it's on my list of resources to do soon (likely within the next two weeks-ish).

@lawrenae
Copy link
Contributor

oh cool -- no worries. Thanks for the update!

@paddycarver
Copy link
Contributor

Assigned to modular-magician, as we're going to be generating this one in the near future, and so PRs are probably gently discouraged. If it's important to get it in ASAP and you're happy to open a PR, though, feel free to shout in this issue and we'll see about switching tack.

@chaitanyaks
Copy link

resource "null_resource" "composer" {
provisioner "local-exec" {
command = "gcloud beta composer environments create ${var.env-name} --location us-east1 --disk-size 20GB --zone us-east1-b --machine-type n1-standard-1 --node-count 3 --labels env=beta"
}
}

@larruda
Copy link

larruda commented Jul 28, 2018

@tdszyman
Copy link

tdszyman commented Aug 7, 2018

Just noting that Cloud Composer is no longer in Beta -- it's been in GA for a few weeks now. This is definitely something I wish was available in TF

@michaelsmithhx
Copy link

We also have a Composer + Terraform requirement so +1 for this feature

@nickithewatt
Copy link
Contributor

@danawillow @emilymye Is there any update on when this feature may be implemented? If this Magic Modules implementation is some way off, are you open to a PR via the more traditional route? Thanks!

@emilymye
Copy link
Contributor

@nickithewatt working on this feature, expect a PR shortly :)

@nickithewatt
Copy link
Contributor

Fantastic, thanks @emilymye

@alan-ma-umg
Copy link

@emilymye thanks so much for getting the PR for composer. Just checking do we have the TF for Composer PR ready?

@ghost
Copy link

ghost commented Nov 16, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests