Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to GKE update node version when there are multiple pools #1274

Closed
Stono opened this issue Mar 30, 2018 · 3 comments
Closed

unable to GKE update node version when there are multiple pools #1274

Stono opened this issue Mar 30, 2018 · 3 comments

Comments

@Stono
Copy link

Stono commented Mar 30, 2018

Hi there,
We have quite a complex GKE setup which uses a google_container_cluster, and then 3x google_container_node_pool as well.

When we come to update the node_version today, we're getting this error:

* module.k8-elastic-cluster.google_container_cluster.cluster: 1 error(s) occurred:

* google_container_cluster.cluster: googleapi: Error 400: Node pool id must be specified if cluster has more than one node pool.., badRequest

So it looks like the google api is wanting you to specify which pool to upgrade so behind the scenes you'd need to iterate over each node_pool and one by one (as you can only do one at a time) upgrade them.

Future
I would suggest that the node_version should actually be an attribute on google_container_node_pool, as pools can be on different versions.

@Stono
Copy link
Author

Stono commented Mar 30, 2018

Linking #1266

@danawillow
Copy link
Contributor

Closing this since it's a duplicate of #633 and is already fixed by #1266 (which will be in the next release, likely next week but no promises)

@ghost
Copy link

ghost commented Nov 19, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants