From 112cd74e572f52a5092cf9f459fa5e0ea2443850 Mon Sep 17 00:00:00 2001 From: The Magician Date: Mon, 10 Dec 2018 08:24:18 -0800 Subject: [PATCH] Remove update_strategy from rigm. (#2594) /cc @rileykarson --- google/resource_compute_region_instance_group_manager.go | 9 ++++----- ...esource_compute_region_instance_group_manager_test.go | 8 +++----- .../compute_region_instance_group_manager.html.markdown | 3 --- 3 files changed, 7 insertions(+), 13 deletions(-) diff --git a/google/resource_compute_region_instance_group_manager.go b/google/resource_compute_region_instance_group_manager.go index 056fe125410..06bbdaf41f2 100644 --- a/google/resource_compute_region_instance_group_manager.go +++ b/google/resource_compute_region_instance_group_manager.go @@ -153,11 +153,10 @@ func resourceComputeRegionInstanceGroupManager() *schema.Resource { }, "update_strategy": &schema.Schema{ - Type: schema.TypeString, - Deprecated: "This field is deprecated as it has no functionality anymore. It will be removed in 3.0.0.", - Optional: true, - Computed: true, - ValidateFunc: validation.StringInSlice([]string{"NONE", "ROLLING_UPDATE"}, false), + Type: schema.TypeString, + Deprecated: "This field is removed.", + Optional: true, + Computed: true, }, "target_pools": &schema.Schema{ diff --git a/google/resource_compute_region_instance_group_manager_test.go b/google/resource_compute_region_instance_group_manager_test.go index b6d4fc2b553..313c4bcf46f 100644 --- a/google/resource_compute_region_instance_group_manager_test.go +++ b/google/resource_compute_region_instance_group_manager_test.go @@ -143,10 +143,9 @@ func TestAccRegionInstanceGroupManager_updateStrategy(t *testing.T) { Config: testAccRegionInstanceGroupManager_updateStrategy(igm), }, { - ResourceName: "google_compute_region_instance_group_manager.igm-update-strategy", - ImportState: true, - ImportStateVerify: true, - ImportStateVerifyIgnore: []string{"update_strategy"}, + ResourceName: "google_compute_region_instance_group_manager.igm-update-strategy", + ImportState: true, + ImportStateVerify: true, }, }, }) @@ -648,7 +647,6 @@ resource "google_compute_region_instance_group_manager" "igm-update-strategy" { base_instance_name = "rigm-update-strategy" region = "us-central1" target_size = 2 - update_strategy = "NONE" named_port { name = "customhttp" port = 8080 diff --git a/website/docs/r/compute_region_instance_group_manager.html.markdown b/website/docs/r/compute_region_instance_group_manager.html.markdown index 2b511f366b2..acbffd0d15a 100644 --- a/website/docs/r/compute_region_instance_group_manager.html.markdown +++ b/website/docs/r/compute_region_instance_group_manager.html.markdown @@ -116,9 +116,6 @@ The following arguments are supported: * `project` - (Optional) The ID of the project in which the resource belongs. If it is not provided, the provider project is used. -* `update_strategy` - (Optional, Default `"NONE"`) This field is deprecated as it has no functionality anymore. -It previously turned update behaviour on and off. This field is only present in the `google` provider. - * `target_size` - (Optional) The target number of running instances for this managed instance group. This value should always be explicitly set unless this resource is attached to an autoscaler, in which case it should never be set. Defaults to `0`.