Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eventhub_namespace for ZoneRedundant property #7534

Merged
merged 6 commits into from
Jul 1, 2020
Merged

Update eventhub_namespace for ZoneRedundant property #7534

merged 6 commits into from
Jul 1, 2020

Conversation

favoretti
Copy link
Collaborator

Adds zone_redundant property to eventhub_namespace resource and
datasource.

Fixes #4872

Adds `zone_redundant` property to `eventhub_namespace` resource and
datasource.

Fixes #4872
@favoretti favoretti changed the title Update eventhub_namespace for ZoneRedundant property Update eventhub_namespace for ZoneRedundant property Jun 30, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @favoretti

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can add an acceptance test covering this and update the documentation then this should otherwise be good to merge 👍

Thanks!

website/docs/d/eventhub_namespace.html.markdown Outdated Show resolved Hide resolved
website/docs/r/eventhub_namespace.html.markdown Outdated Show resolved Hide resolved
@ghost ghost added size/S and removed size/XS labels Jun 30, 2020
@favoretti favoretti requested a review from tombuildsstuff June 30, 2020 10:27
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @favoretti

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @favoretti

I've run the tests for this which caught that this field is being submitted to Azure but not set into the Statefile - could we update the Read function to ensure this is also set?

Thanks!

@favoretti favoretti requested a review from tombuildsstuff July 1, 2020 10:45
@tombuildsstuff
Copy link
Contributor

Tests look good 👍

@tombuildsstuff tombuildsstuff merged commit d9c7c7e into hashicorp:master Jul 1, 2020
tombuildsstuff added a commit that referenced this pull request Jul 1, 2020
@ghost
Copy link

ghost commented Jul 3, 2020

This has been released in version 2.17.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.17.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for zoneRedundant property of azurerm_eventhub_namespace
2 participants