-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eventhub_namespace for ZoneRedundant property #7534
Update eventhub_namespace for ZoneRedundant property #7534
Conversation
Adds `zone_redundant` property to `eventhub_namespace` resource and datasource. Fixes #4872
ZoneRedundant
propertyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @favoretti
Thanks for this PR :)
Taking a look through this mostly LGTM - if we can add an acceptance test covering this and update the documentation then this should otherwise be good to merge 👍
Thanks!
Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for pushing those changes @favoretti
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @favoretti
I've run the tests for this which caught that this field is being submitted to Azure but not set into the Statefile - could we update the Read function to ensure this is also set?
Thanks!
Tests look good 👍 |
This has been released in version 2.17.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.17.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Adds
zone_redundant
property toeventhub_namespace
resource anddatasource.
Fixes #4872