-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resources: iothub_endpoint_storage_container
, iothub_endpoint_eventhub
, iothub_endpoint_servicebus_queue
, iothub_endpoint_servicebus_topic
#3672
Conversation
9949e00
to
b1872b8
Compare
b1872b8
to
2973b30
Compare
iothub_endpoint_storage_container
iothub_endpoint_storage_container
, iothub_endpoint_eventhub
, iothub_endpoint_servicebus_queue
, iothub_endpoint_servicebus_topic
3ba319f
to
650ef79
Compare
Those four resources have obviously very similar implementations. I wonder if it wouldn't be good to refactor and extract the code that is common to all four resources. What do you think? |
Is there any chance for someone to look at this PR? Maybe I should split it into smaller ones? |
650ef79
to
adfb376
Compare
anybody? |
03ede11
to
c2aeb9a
Compare
68fce8c
to
c2aeb9a
Compare
Hey @maxbog. Apologies for the delay in getting this one and the other PRs in. I took a look and this mostly looks great. It's just missing best practices in the provider that have changed with how long this has been around. I've taken a crack at getting those in so you wouldn't have to but I couldn't merge it in cleanly since we haven't looked at this in so long. I've opened up a separate PR here #4823 that has all your commits and a couple of mine layered on top to get it up to snuff with the master branch of the provider. Let me know if those look ok and we'll get it reviewed on more time before getting it in |
@mbfrahry Your changes look fine for me. Would be great to have your PR in :D |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Extracts Endpoint resources from IoTHub.
See #3303