Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resources: iothub_endpoint_storage_container, iothub_endpoint_eventhub, iothub_endpoint_servicebus_queue, iothub_endpoint_servicebus_topic #3672

Closed
wants to merge 5 commits into from

Conversation

maxbog
Copy link
Contributor

@maxbog maxbog commented Jun 14, 2019

Extracts Endpoint resources from IoTHub.

See #3303

@maxbog maxbog force-pushed the f/iothub_endpoints branch 5 times, most recently from 9949e00 to b1872b8 Compare June 14, 2019 20:53
@maxbog maxbog force-pushed the f/iothub_endpoints branch from b1872b8 to 2973b30 Compare June 16, 2019 20:59
@ghost ghost added size/XXL and removed size/XL labels Jun 16, 2019
@maxbog maxbog changed the title New resource: iothub_endpoint_storage_container New resources: iothub_endpoint_storage_container, iothub_endpoint_eventhub, iothub_endpoint_servicebus_queue, iothub_endpoint_servicebus_topic Jun 16, 2019
@maxbog maxbog force-pushed the f/iothub_endpoints branch from 3ba319f to 650ef79 Compare June 17, 2019 07:53
@maxbog
Copy link
Contributor Author

maxbog commented Jun 17, 2019

Those four resources have obviously very similar implementations. I wonder if it wouldn't be good to refactor and extract the code that is common to all four resources.

What do you think?

@maxbog
Copy link
Contributor Author

maxbog commented Jul 1, 2019

Is there any chance for someone to look at this PR? Maybe I should split it into smaller ones?

@maxbog
Copy link
Contributor Author

maxbog commented Aug 19, 2019

anybody?

@maxbog maxbog force-pushed the f/iothub_endpoints branch from 03ede11 to c2aeb9a Compare August 19, 2019 13:11
@tombuildsstuff tombuildsstuff modified the milestones: v1.33.0, v1.34.0 Aug 21, 2019
@tombuildsstuff tombuildsstuff removed this from the v1.34.0 milestone Sep 12, 2019
@mbfrahry
Copy link
Member

mbfrahry commented Nov 7, 2019

Hey @maxbog. Apologies for the delay in getting this one and the other PRs in. I took a look and this mostly looks great. It's just missing best practices in the provider that have changed with how long this has been around. I've taken a crack at getting those in so you wouldn't have to but I couldn't merge it in cleanly since we haven't looked at this in so long. I've opened up a separate PR here #4823 that has all your commits and a couple of mine layered on top to get it up to snuff with the master branch of the provider. Let me know if those look ok and we'll get it reviewed on more time before getting it in

@maxbog
Copy link
Contributor Author

maxbog commented Nov 8, 2019

@mbfrahry Your changes look fine for me. Would be great to have your PR in :D

@katbyte
Copy link
Collaborator

katbyte commented Nov 18, 2019

I'm going to close this as it's been superseded by #4823, thanks @maxbog & @mbfrahry !

@katbyte katbyte removed this from the v1.38.0 milestone Nov 18, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants