Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource/Data Source: azurerm_api_management_user #2954

Merged
merged 7 commits into from
Feb 27, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR adds support for creating Users inside an API Management Service, which is dependent on #2953.

Whilst the tests for this were working prior to the breaking API change, this is currently also blocked on #2945

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one minor comment LGTM 👍

azurerm/resource_arm_api_management_user.go Outdated Show resolved Hide resolved
@ghost ghost added size/XXL and removed size/XL labels Feb 27, 2019
@tombuildsstuff tombuildsstuff force-pushed the f/api-management-users branch 2 times, most recently from ffaca02 to 8c02a4c Compare February 27, 2019 13:36
@ghost ghost added size/XL and removed size/XXL labels Feb 27, 2019
@tombuildsstuff
Copy link
Contributor Author

Data Source test passes:

screenshot 2019-02-27 at 16 07 46

@tombuildsstuff
Copy link
Contributor Author

Resource Tests pass:

screenshot 2019-02-27 at 22 14 34

screenshot 2019-02-27 at 22 14 07

@tombuildsstuff tombuildsstuff merged commit f6b1708 into master Feb 27, 2019
@tombuildsstuff tombuildsstuff deleted the f/api-management-users branch February 27, 2019 21:16
tombuildsstuff added a commit that referenced this pull request Feb 27, 2019
@ghost
Copy link

ghost commented Mar 8, 2019

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 30, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants