Upgrade containerapps API version from 2023-05-01
to 2024-03-01
#28074
+103
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to add
additionalPortMappings
support for ingress inazurerm_container_app
resource, so we need this pr to bump API version first. This pr is 1/2 pr to solve #23442.When I ran the tests I found that
TestAccContainerAppResource_workloadProfileUpdate
failed, this pr also fixed it by adjusting the testing config. The original implementation ofazurerm_container_app_environment
resource indicates that onceworkload_profile
's length has been changed from or to0
, the environment would be recreated, which caused a recreation on the container app resource. I don't think testing recreation makes sense so I adjust the test config, switch the workload profile that our container app uses, to verify whether users can change the workload profile.Community Note
Description
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
=== RUN TestAccContainerAppResource_basic
=== PAUSE TestAccContainerAppResource_basic
=== RUN TestAccContainerAppResource_workloadProfile
=== PAUSE TestAccContainerAppResource_workloadProfile
=== RUN TestAccContainerAppResource_smallerGranularityCPUMemoryCombinations
=== PAUSE TestAccContainerAppResource_smallerGranularityCPUMemoryCombinations
=== RUN TestAccContainerAppResource_workloadProfileUpdate
=== PAUSE TestAccContainerAppResource_workloadProfileUpdate
=== RUN TestAccContainerAppResource_withSystemAssignedIdentity
=== PAUSE TestAccContainerAppResource_withSystemAssignedIdentity
=== RUN TestAccContainerAppResource_withUserAssignedIdentity
=== PAUSE TestAccContainerAppResource_withUserAssignedIdentity
=== RUN TestAccContainerAppResource_withSystemAndUserAssignedIdentity
=== PAUSE TestAccContainerAppResource_withSystemAndUserAssignedIdentity
=== RUN TestAccContainerAppResource_withIdentityUpdate
=== PAUSE TestAccContainerAppResource_withIdentityUpdate
=== RUN TestAccContainerAppResource_withKeyVaultSecretVersioningUpdate
=== PAUSE TestAccContainerAppResource_withKeyVaultSecretVersioningUpdate
=== RUN TestAccContainerAppResource_withKeyVaultSecretIdentityUpdate
=== PAUSE TestAccContainerAppResource_withKeyVaultSecretIdentityUpdate
=== RUN TestAccContainerAppResource_basicUpdate
=== PAUSE TestAccContainerAppResource_basicUpdate
=== RUN TestAccContainerAppResource_requiresImport
=== PAUSE TestAccContainerAppResource_requiresImport
=== RUN TestAccContainerAppResource_complete
=== PAUSE TestAccContainerAppResource_complete
=== RUN TestAccContainerAppResource_completeVolumeEmptyDir
=== PAUSE TestAccContainerAppResource_completeVolumeEmptyDir
=== RUN TestAccContainerAppResource_completeWithNoDaprAppPort
=== PAUSE TestAccContainerAppResource_completeWithNoDaprAppPort
=== RUN TestAccContainerAppResource_completeWithVNet
=== PAUSE TestAccContainerAppResource_completeWithVNet
=== RUN TestAccContainerAppResource_completeWithSidecar
=== PAUSE TestAccContainerAppResource_completeWithSidecar
=== RUN TestAccContainerAppResource_completeWithMultipleContainers
=== PAUSE TestAccContainerAppResource_completeWithMultipleContainers
=== RUN TestAccContainerAppResource_completeUpdate
=== PAUSE TestAccContainerAppResource_completeUpdate
=== RUN TestAccContainerAppResource_completeTcpExposedPort
=== PAUSE TestAccContainerAppResource_completeTcpExposedPort
=== RUN TestAccContainerAppResource_removeDaprAppPort
=== PAUSE TestAccContainerAppResource_removeDaprAppPort
=== RUN TestAccContainerAppResource_secretChangeName
=== PAUSE TestAccContainerAppResource_secretChangeName
=== RUN TestAccContainerAppResource_secretRemove
=== PAUSE TestAccContainerAppResource_secretRemove
=== RUN TestAccContainerAppResource_scaleRules
=== PAUSE TestAccContainerAppResource_scaleRules
=== RUN TestAccContainerAppResource_multipleScaleRules
=== PAUSE TestAccContainerAppResource_multipleScaleRules
=== RUN TestAccContainerAppResource_scaleRulesUpdate
=== PAUSE TestAccContainerAppResource_scaleRulesUpdate
=== RUN TestAccContainerAppResource_ipSecurityRulesUpdate
=== PAUSE TestAccContainerAppResource_ipSecurityRulesUpdate
=== RUN TestAccContainerAppResource_ingressTrafficValidation
=== PAUSE TestAccContainerAppResource_ingressTrafficValidation
=== RUN TestAccContainerAppResource_maxInactiveRevisionsUpdate
=== PAUSE TestAccContainerAppResource_maxInactiveRevisionsUpdate
=== CONT TestAccContainerAppResource_basic
=== CONT TestAccContainerAppResource_completeWithVNet
=== CONT TestAccContainerAppResource_maxInactiveRevisionsUpdate
=== CONT TestAccContainerAppResource_ingressTrafficValidation
=== CONT TestAccContainerAppResource_ipSecurityRulesUpdate
=== CONT TestAccContainerAppResource_scaleRulesUpdate
=== CONT TestAccContainerAppResource_multipleScaleRules
=== CONT TestAccContainerAppResource_scaleRules
=== CONT TestAccContainerAppResource_secretRemove
=== CONT TestAccContainerAppResource_secretChangeName
=== CONT TestAccContainerAppResource_removeDaprAppPort
=== CONT TestAccContainerAppResource_completeTcpExposedPort
=== CONT TestAccContainerAppResource_completeUpdate
=== CONT TestAccContainerAppResource_completeWithMultipleContainers
=== CONT TestAccContainerAppResource_completeWithSidecar
--- PASS: TestAccContainerAppResource_ingressTrafficValidation (32.99s)
=== CONT TestAccContainerAppResource_complete
--- PASS: TestAccContainerAppResource_completeWithMultipleContainers (527.72s)
=== CONT TestAccContainerAppResource_completeWithNoDaprAppPort
--- PASS: TestAccContainerAppResource_secretRemove (592.14s)
=== CONT TestAccContainerAppResource_completeVolumeEmptyDir
--- PASS: TestAccContainerAppResource_basic (597.63s)
=== CONT TestAccContainerAppResource_withSystemAssignedIdentity
--- PASS: TestAccContainerAppResource_multipleScaleRules (604.93s)
=== CONT TestAccContainerAppResource_withIdentityUpdate
--- PASS: TestAccContainerAppResource_scaleRules (609.67s)
=== CONT TestAccContainerAppResource_withSystemAndUserAssignedIdentity
--- PASS: TestAccContainerAppResource_completeUpdate (667.16s)
=== CONT TestAccContainerAppResource_withUserAssignedIdentity
--- PASS: TestAccContainerAppResource_secretChangeName (677.19s)
=== CONT TestAccContainerAppResource_basicUpdate
--- PASS: TestAccContainerAppResource_maxInactiveRevisionsUpdate (684.18s)
=== CONT TestAccContainerAppResource_requiresImport
--- PASS: TestAccContainerAppResource_completeWithSidecar (699.04s)
=== CONT TestAccContainerAppResource_smallerGranularityCPUMemoryCombinations
--- PASS: TestAccContainerAppResource_complete (673.29s)
=== CONT TestAccContainerAppResource_workloadProfileUpdate
--- PASS: TestAccContainerAppResource_removeDaprAppPort (778.25s)
=== CONT TestAccContainerAppResource_withKeyVaultSecretIdentityUpdate
--- PASS: TestAccContainerAppResource_scaleRulesUpdate (782.57s)
=== RUN TestAccContainerAppResource_workloadProfileUpdate
=== PAUSE TestAccContainerAppResource_workloadProfileUpdate
=== CONT TestAccContainerAppResource_workloadProfileUpdate
--- PASS: TestAccContainerAppResource_workloadProfileUpdate (2576.16s)
--- PASS: TestAccContainerAppResource_ipSecurityRulesUpdate (856.13s)
=== CONT TestAccContainerAppResource_withKeyVaultSecretVersioningUpdate
--- PASS: TestAccContainerAppResource_completeTcpExposedPort (973.30s)
--- PASS: TestAccContainerAppResource_completeWithVNet (985.47s)
--- PASS: TestAccContainerAppResource_withSystemAssignedIdentity (468.32s)
--- PASS: TestAccContainerAppResource_withSystemAndUserAssignedIdentity (469.18s)
--- PASS: TestAccContainerAppResource_completeWithNoDaprAppPort (678.58s)
--- PASS: TestAccContainerAppResource_requiresImport (522.30s)
--- PASS: TestAccContainerAppResource_withUserAssignedIdentity (585.41s)
--- PASS: TestAccContainerAppResource_completeVolumeEmptyDir (672.07s)
--- PASS: TestAccContainerAppResource_basicUpdate (644.13s)
--- PASS: TestAccContainerAppResource_withIdentityUpdate (716.41s)
--- PASS: TestAccContainerAppResource_withKeyVaultSecretVersioningUpdate (1009.85s)
--- PASS: TestAccContainerAppResource_withKeyVaultSecretIdentityUpdate (1159.14s)
--- PASS: TestAccContainerAppResource_workloadProfile (1965.37s)
--- PASS: TestAccContainerAppResource_smallerGranularityCPUMemoryCombinations (2167.54s)
=== RUN TestAccContainerAppDataSource_basic
=== PAUSE TestAccContainerAppDataSource_basic
=== RUN TestAccContainerAppDataSource_complete
=== PAUSE TestAccContainerAppDataSource_complete
=== CONT TestAccContainerAppDataSource_basic
=== CONT TestAccContainerAppDataSource_complete
--- PASS: TestAccContainerAppDataSource_basic (588.53s)
--- PASS: TestAccContainerAppDataSource_complete (598.09s)
I don't have custom dns to run test in
container_app_custom_domain_resource_test.go
file, but since it's just a simple API version bump I think maybe it's ok. Please let me know if I must submit the test results from this file, thanks!Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
2023-05-01
to2024-03-01
Support for additionalPortMappings in azurerm_container_app #23442This is a (please select all that apply):
Related Issue(s)
#23442
Note
If this PR changes meaningfully during the course of review please update the title and description as required.