Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade containerapps API version from 2023-05-01 to 2024-03-01 #28074

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

lonegunmanb
Copy link
Contributor

@lonegunmanb lonegunmanb commented Nov 20, 2024

I'd like to add additionalPortMappings support for ingress in azurerm_container_app resource, so we need this pr to bump API version first. This pr is 1/2 pr to solve #23442.

When I ran the tests I found that TestAccContainerAppResource_workloadProfileUpdate failed, this pr also fixed it by adjusting the testing config. The original implementation of azurerm_container_app_environment resource indicates that once workload_profile's length has been changed from or to 0, the environment would be recreated, which caused a recreation on the container app resource. I don't think testing recreation makes sense so I adjust the test config, switch the workload profile that our container app uses, to verify whether users can change the workload profile.

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

=== RUN TestAccContainerAppResource_basic
=== PAUSE TestAccContainerAppResource_basic
=== RUN TestAccContainerAppResource_workloadProfile
=== PAUSE TestAccContainerAppResource_workloadProfile
=== RUN TestAccContainerAppResource_smallerGranularityCPUMemoryCombinations
=== PAUSE TestAccContainerAppResource_smallerGranularityCPUMemoryCombinations
=== RUN TestAccContainerAppResource_workloadProfileUpdate
=== PAUSE TestAccContainerAppResource_workloadProfileUpdate
=== RUN TestAccContainerAppResource_withSystemAssignedIdentity
=== PAUSE TestAccContainerAppResource_withSystemAssignedIdentity
=== RUN TestAccContainerAppResource_withUserAssignedIdentity
=== PAUSE TestAccContainerAppResource_withUserAssignedIdentity
=== RUN TestAccContainerAppResource_withSystemAndUserAssignedIdentity
=== PAUSE TestAccContainerAppResource_withSystemAndUserAssignedIdentity
=== RUN TestAccContainerAppResource_withIdentityUpdate
=== PAUSE TestAccContainerAppResource_withIdentityUpdate
=== RUN TestAccContainerAppResource_withKeyVaultSecretVersioningUpdate
=== PAUSE TestAccContainerAppResource_withKeyVaultSecretVersioningUpdate
=== RUN TestAccContainerAppResource_withKeyVaultSecretIdentityUpdate
=== PAUSE TestAccContainerAppResource_withKeyVaultSecretIdentityUpdate
=== RUN TestAccContainerAppResource_basicUpdate
=== PAUSE TestAccContainerAppResource_basicUpdate
=== RUN TestAccContainerAppResource_requiresImport
=== PAUSE TestAccContainerAppResource_requiresImport
=== RUN TestAccContainerAppResource_complete
=== PAUSE TestAccContainerAppResource_complete
=== RUN TestAccContainerAppResource_completeVolumeEmptyDir
=== PAUSE TestAccContainerAppResource_completeVolumeEmptyDir
=== RUN TestAccContainerAppResource_completeWithNoDaprAppPort
=== PAUSE TestAccContainerAppResource_completeWithNoDaprAppPort
=== RUN TestAccContainerAppResource_completeWithVNet
=== PAUSE TestAccContainerAppResource_completeWithVNet
=== RUN TestAccContainerAppResource_completeWithSidecar
=== PAUSE TestAccContainerAppResource_completeWithSidecar
=== RUN TestAccContainerAppResource_completeWithMultipleContainers
=== PAUSE TestAccContainerAppResource_completeWithMultipleContainers
=== RUN TestAccContainerAppResource_completeUpdate
=== PAUSE TestAccContainerAppResource_completeUpdate
=== RUN TestAccContainerAppResource_completeTcpExposedPort
=== PAUSE TestAccContainerAppResource_completeTcpExposedPort
=== RUN TestAccContainerAppResource_removeDaprAppPort
=== PAUSE TestAccContainerAppResource_removeDaprAppPort
=== RUN TestAccContainerAppResource_secretChangeName
=== PAUSE TestAccContainerAppResource_secretChangeName
=== RUN TestAccContainerAppResource_secretRemove
=== PAUSE TestAccContainerAppResource_secretRemove
=== RUN TestAccContainerAppResource_scaleRules
=== PAUSE TestAccContainerAppResource_scaleRules
=== RUN TestAccContainerAppResource_multipleScaleRules
=== PAUSE TestAccContainerAppResource_multipleScaleRules
=== RUN TestAccContainerAppResource_scaleRulesUpdate
=== PAUSE TestAccContainerAppResource_scaleRulesUpdate
=== RUN TestAccContainerAppResource_ipSecurityRulesUpdate
=== PAUSE TestAccContainerAppResource_ipSecurityRulesUpdate
=== RUN TestAccContainerAppResource_ingressTrafficValidation
=== PAUSE TestAccContainerAppResource_ingressTrafficValidation
=== RUN TestAccContainerAppResource_maxInactiveRevisionsUpdate
=== PAUSE TestAccContainerAppResource_maxInactiveRevisionsUpdate
=== CONT TestAccContainerAppResource_basic
=== CONT TestAccContainerAppResource_completeWithVNet
=== CONT TestAccContainerAppResource_maxInactiveRevisionsUpdate
=== CONT TestAccContainerAppResource_ingressTrafficValidation
=== CONT TestAccContainerAppResource_ipSecurityRulesUpdate
=== CONT TestAccContainerAppResource_scaleRulesUpdate
=== CONT TestAccContainerAppResource_multipleScaleRules
=== CONT TestAccContainerAppResource_scaleRules
=== CONT TestAccContainerAppResource_secretRemove
=== CONT TestAccContainerAppResource_secretChangeName
=== CONT TestAccContainerAppResource_removeDaprAppPort
=== CONT TestAccContainerAppResource_completeTcpExposedPort
=== CONT TestAccContainerAppResource_completeUpdate
=== CONT TestAccContainerAppResource_completeWithMultipleContainers
=== CONT TestAccContainerAppResource_completeWithSidecar
--- PASS: TestAccContainerAppResource_ingressTrafficValidation (32.99s)
=== CONT TestAccContainerAppResource_complete
--- PASS: TestAccContainerAppResource_completeWithMultipleContainers (527.72s)
=== CONT TestAccContainerAppResource_completeWithNoDaprAppPort
--- PASS: TestAccContainerAppResource_secretRemove (592.14s)
=== CONT TestAccContainerAppResource_completeVolumeEmptyDir
--- PASS: TestAccContainerAppResource_basic (597.63s)
=== CONT TestAccContainerAppResource_withSystemAssignedIdentity
--- PASS: TestAccContainerAppResource_multipleScaleRules (604.93s)
=== CONT TestAccContainerAppResource_withIdentityUpdate
--- PASS: TestAccContainerAppResource_scaleRules (609.67s)
=== CONT TestAccContainerAppResource_withSystemAndUserAssignedIdentity
--- PASS: TestAccContainerAppResource_completeUpdate (667.16s)
=== CONT TestAccContainerAppResource_withUserAssignedIdentity
--- PASS: TestAccContainerAppResource_secretChangeName (677.19s)
=== CONT TestAccContainerAppResource_basicUpdate
--- PASS: TestAccContainerAppResource_maxInactiveRevisionsUpdate (684.18s)
=== CONT TestAccContainerAppResource_requiresImport
--- PASS: TestAccContainerAppResource_completeWithSidecar (699.04s)
=== CONT TestAccContainerAppResource_smallerGranularityCPUMemoryCombinations
--- PASS: TestAccContainerAppResource_complete (673.29s)
=== CONT TestAccContainerAppResource_workloadProfileUpdate
--- PASS: TestAccContainerAppResource_removeDaprAppPort (778.25s)
=== CONT TestAccContainerAppResource_withKeyVaultSecretIdentityUpdate
--- PASS: TestAccContainerAppResource_scaleRulesUpdate (782.57s)
=== RUN TestAccContainerAppResource_workloadProfileUpdate
=== PAUSE TestAccContainerAppResource_workloadProfileUpdate
=== CONT TestAccContainerAppResource_workloadProfileUpdate
--- PASS: TestAccContainerAppResource_workloadProfileUpdate (2576.16s)
--- PASS: TestAccContainerAppResource_ipSecurityRulesUpdate (856.13s)
=== CONT TestAccContainerAppResource_withKeyVaultSecretVersioningUpdate
--- PASS: TestAccContainerAppResource_completeTcpExposedPort (973.30s)
--- PASS: TestAccContainerAppResource_completeWithVNet (985.47s)
--- PASS: TestAccContainerAppResource_withSystemAssignedIdentity (468.32s)
--- PASS: TestAccContainerAppResource_withSystemAndUserAssignedIdentity (469.18s)
--- PASS: TestAccContainerAppResource_completeWithNoDaprAppPort (678.58s)
--- PASS: TestAccContainerAppResource_requiresImport (522.30s)
--- PASS: TestAccContainerAppResource_withUserAssignedIdentity (585.41s)
--- PASS: TestAccContainerAppResource_completeVolumeEmptyDir (672.07s)
--- PASS: TestAccContainerAppResource_basicUpdate (644.13s)
--- PASS: TestAccContainerAppResource_withIdentityUpdate (716.41s)
--- PASS: TestAccContainerAppResource_withKeyVaultSecretVersioningUpdate (1009.85s)
--- PASS: TestAccContainerAppResource_withKeyVaultSecretIdentityUpdate (1159.14s)
--- PASS: TestAccContainerAppResource_workloadProfile (1965.37s)
--- PASS: TestAccContainerAppResource_smallerGranularityCPUMemoryCombinations (2167.54s)
=== RUN TestAccContainerAppDataSource_basic
=== PAUSE TestAccContainerAppDataSource_basic
=== RUN TestAccContainerAppDataSource_complete
=== PAUSE TestAccContainerAppDataSource_complete
=== CONT TestAccContainerAppDataSource_basic
=== CONT TestAccContainerAppDataSource_complete
--- PASS: TestAccContainerAppDataSource_basic (588.53s)
--- PASS: TestAccContainerAppDataSource_complete (598.09s)

I don't have custom dns to run test in container_app_custom_domain_resource_test.go file, but since it's just a simple API version bump I think maybe it's ok. Please let me know if I must submit the test results from this file, thanks!

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

#23442

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lonegunmanb LGTM 👍

@stephybun stephybun merged commit e9967ed into hashicorp:main Nov 27, 2024
36 checks passed
@github-actions github-actions bot added this to the v4.12.0 milestone Nov 27, 2024
stephybun added a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants