Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_search_service - support attribute customer_managed_key_encryption_compliance_status #27478

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

liuwuliuyun
Copy link
Contributor

…search_service

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Customer now is blocked to create AI Search resource due to missing setting of encryptionComplianceStatus while deploying service via Terraform template. Basically, only enforcement property is supported to be inserted in Terraform, while 'Microsoft.Search/searchServices/encryptionWithCmk.encryptionComplianceStatus' is not available in Terraform.

  1. Add readonly attribute customer_managed_key_encryption_compliance_status to azurerm_search_service resource
  2. Add the same attribute for datasource azurerm_search_service as well
  3. Updating document accordingly

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
GOROOT=C:\Users\<alias>\go\go1.22.7 #gosetup
GOPATH=C:\Users\<alias>\go #gosetup
C:\Users\<alias>\go\go1.22.7\bin\go.exe test -c -o C:\Users\<alias>\<golandpath>\___TestAccDataSourceSearchService_basic_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_search.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/search #gosetup
C:\Users\<alias>\go\go1.22.7\bin\go.exe tool test2json -t C:\Users\<alias>\<golandpath>\___TestAccDataSourceSearchService_basic_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_search.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccDataSourceSearchService_basic\E$ #gosetup
=== RUN   TestAccDataSourceSearchService_basic
=== PAUSE TestAccDataSourceSearchService_basic
=== CONT  TestAccDataSourceSearchService_basic
--- PASS: TestAccDataSourceSearchService_basic (508.04s)
PASS


Process finished with the exit code 0

GOROOT=C:\Users\<alias>\go\go1.22.7 #gosetup
GOPATH=C:\Users\<alias>\go #gosetup
C:\Users\<alias>\go\go1.22.7\bin\go.exe test -c -o C:\Users\<alias>\<golandpath>\___TestAccSearchService_customerManagedKeyEnforcement_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_search.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/search #gosetup
C:\Users\<alias>\go\go1.22.7\bin\go.exe tool test2json -t C:\Users\<alias>\<golandpath>\___TestAccSearchService_customerManagedKeyEnforcement_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_search.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccSearchService_customerManagedKeyEnforcement\E$ #gosetup
=== RUN   TestAccSearchService_customerManagedKeyEnforcement
=== PAUSE TestAccSearchService_customerManagedKeyEnforcement
=== CONT  TestAccSearchService_customerManagedKeyEnforcement
--- PASS: TestAccSearchService_customerManagedKeyEnforcement (183.91s)
PASS


Process finished with the exit code 0

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_search_service - support attribute customer_managed_key_encryption_compliance_status [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiple test failures
image

@liuwuliuyun
Copy link
Contributor Author

image
The test failures appear to be region-specific. Upon rerunning the tests, they were successful.

@katbyte katbyte requested a review from a team as a code owner November 14, 2024 00:08
internal/services/search/search_service_data_source.go Outdated Show resolved Hide resolved
internal/services/search/search_service_resource.go Outdated Show resolved Hide resolved
website/docs/d/search_service.html.markdown Outdated Show resolved Hide resolved
website/docs/r/search_service.html.markdown Outdated Show resolved Hide resolved
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liuwuliuyun LGTM 👍

@stephybun stephybun merged commit 72efe20 into hashicorp:main Nov 25, 2024
33 checks passed
@github-actions github-actions bot added this to the v4.12.0 milestone Nov 25, 2024
stephybun added a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants