Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split remaining CreateUpdate functions for maintenance and managedapplications #25371

Merged
merged 8 commits into from
Mar 22, 2024
Merged

Split remaining CreateUpdate functions for maintenance and managedapplications #25371

merged 8 commits into from
Mar 22, 2024

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Mar 22, 2024 •
edited
Loading

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Splits resources with combined create and update functions in the maintenance and managedapplications services.

Testing

Tests looks good

image image

tombuildsstuff
tombuildsstuff approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor points about timeouts but 👍

@stephybun stephybun changed the title Split remaining CreateUpdate functions for logz, maintenance and managedapplications Split remaining CreateUpdate functions for maintenance and managedapplications Mar 22, 2024
@github-actions github-actions bot added size/L and removed size/XL labels Mar 22, 2024
@stephybun stephybun merged commit ac13fcc into main Mar 22, 2024
29 checks passed
@stephybun stephybun deleted the r/split-create-update branch March 22, 2024 11:01
@github-actions github-actions bot added this to the v3.98.0 milestone Mar 22, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
service/maintenance service/managed-apps size/L
Projects
None yet
Milestone
v3.98.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stephybun @tombuildsstuff