New Resource: `azurerm_workloads_sap_discovery_virtual_instance` #24342

neil-yechenwei · 2023-12-27T08:36:17Z

Per #22869 (comment), I split the SAP Virtual Instance per the configuration type. See more details from #22869 (comment).

--- PASS: TestAccWorkloadsSAPDiscoveryVirtualInstanceSequential/sapVirtualInstance/requiresImport (939.89s)
--- PASS: TestAccWorkloadsSAPDiscoveryVirtualInstanceSequential/sapVirtualInstance/complete (699.58s)
--- PASS: TestAccWorkloadsSAPDiscoveryVirtualInstanceSequential/sapVirtualInstance/update (731.28s)
--- PASS: TestAccWorkloadsSAPDiscoveryVirtualInstanceSequential/sapVirtualInstance/basic (699.47s)

Note: Before using this resource, it's required to submit the request of registering the Resource Provider with Azure CLI az provider register --namespace "Microsoft.Workloads". The Resource Provider can take a while to register, you can check the status by running az provider show --namespace "Microsoft.Workloads" --query "registrationState". Once this outputs "Registered" the Resource Provider is available for use. I also added this note in the resource doc.

References:
Azure doc
REST API specs

ms-zhenhua

Hey @neil-yechenwei
Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

Thanks!

internal/services/workloads/validate/sap_virtual_instance_name.go

internal/services/workloads/workloads_sap_discovery_virtual_instance_resource.go

internal/services/workloads/workloads_sap_discovery_virtual_instance_resource_test.go

website/docs/r/workloads_sap_discovery_virtual_instance.html.markdown

neil-yechenwei · 2024-01-04T08:15:17Z

@ms-zhenhua , thanks for the comments. I updated PR. Please take another look. Thanks.

ms-zhenhua · 2024-01-17T09:45:15Z

@neil-yechenwei thank you for your updates. LGTM~

tombuildsstuff · 2024-01-25T16:35:46Z

hey @neil-yechenwei

We’ve made some structural changes to hashicorp/go-azure-sdk which have split the SDK into multiple Go Modules. This means that the SDK which previously existed at github.com/hashicorp/go-azure-sdk now exists at:

github.com/hashicorp/go-azure-sdk/resource-manager - for the Resource Manager SDK.
github.com/hashicorp/go-azure-sdk/sdk - for the base layer.

We’ve updated the Provider to use the new Go Module structure in PR #24636 - as such would you mind rebasing this Pull Request on top of main to remove the merge conflict?

Thanks!

neil-yechenwei · 2024-01-26T11:21:39Z

I updated PR for the SDK change.

catriona-m

Thanks @neil-yechenwei - I have left one minor comment and query on this, but otherwise this is looking good!

Also, can you confirm the tests are still passing after the previous changes? Thanks!

catriona-m · 2024-03-05T15:50:33Z

website/docs/r/workloads_sap_discovery_virtual_instance.html.markdown

+
+* `type` - (Required) The type of Managed Service Identity that should be configured on this SAP Discovery Virtual Instance. Only possible value is `UserAssigned`.


Suggested change

* `type` - (Required) The type of Managed Service Identity that should be configured on this SAP Discovery Virtual Instance. Only possible value is `UserAssigned`.

* `type` - (Required) The type of Managed Service Identity that should be configured on this SAP Discovery Virtual Instance. The only possible value is `UserAssigned`.

internal/services/workloads/workloads_sap_discovery_virtual_instance_resource_test.go

neil-yechenwei · 2024-03-08T02:42:17Z

There is a regression issue on the service side and service team intends to fix it this month. So I will paste test result here once this issue is fixed.

neil-yechenwei · 2024-03-27T12:33:07Z

@catriona-m , I just now reran the related test cases and they all passed. Below is the latest test result. Thanks.

--- PASS: TestAccWorkloadsSAPDiscoveryVirtualInstanceSequential/sapVirtualInstance/basic (895.12s)
--- PASS: TestAccWorkloadsSAPDiscoveryVirtualInstanceSequential/sapVirtualInstance/requiresImport (878.68s)
--- PASS: TestAccWorkloadsSAPDiscoveryVirtualInstanceSequential/sapVirtualInstance/complete (934.58s)
--- PASS: TestAccWorkloadsSAPDiscoveryVirtualInstanceSequential/sapVirtualInstance/update (897.12s)

neil-yechenwei · 2024-04-02T00:25:54Z

@catriona-m , Is this PR good to be merged?

catriona-m

Thanks @neil-yechenwei - I spotted a couple of rg test names that could be updated, but once those are fixed this should be good to go 👍. Thanks!

catriona-m · 2024-04-02T10:06:02Z

internal/services/workloads/workloads_sap_discovery_virtual_instance_resource_test.go

+  location                          = azurerm_resource_group.test.location
+  environment                       = "NonProd"
+  sap_product                       = "S4HANA"
+  managed_resource_group_name       = "managedTestRG%d"


Suggested change

managed_resource_group_name = "managedTestRG%d"

managed_resource_group_name = "acctestmanagedRG%d"

catriona-m · 2024-04-02T10:06:49Z

internal/services/workloads/workloads_sap_discovery_virtual_instance_resource_test.go

+  location                          = azurerm_resource_group.test.location
+  environment                       = "NonProd"
+  sap_product                       = "S4HANA"
+  managed_resource_group_name       = "managedTestRG%d"


Suggested change

managed_resource_group_name = "managedTestRG%d"

managed_resource_group_name = "acctestmanagedRG%d"

neil-yechenwei · 2024-04-03T07:01:46Z

@catriona-m , thanks for the comment. I updated PR and reran the related test cases. Below is the test result.

--- PASS: TestAccWorkloadsSAPDiscoveryVirtualInstanceSequential/sapVirtualInstance/update (1388.07s)
--- PASS: TestAccWorkloadsSAPDiscoveryVirtualInstanceSequential/sapVirtualInstance/basic (1012.23s)
--- PASS: TestAccWorkloadsSAPDiscoveryVirtualInstanceSequential/sapVirtualInstance/requiresImport (1146.39s)
--- PASS: TestAccWorkloadsSAPDiscoveryVirtualInstanceSequential/sapVirtualInstance/complete (1170.18s)

catriona-m

Thanks @neil-yechenwei LGTM!

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.97.1" to "3.98.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.98.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.98.0
FEATURES:

* New Resource: `azurerm_static_web_app_function_app_registration` ([#25331](hashicorp/terraform-provider-azurerm#25331 New Resource: `azurerm_system_center_virtual_machine_manager_inventory_items` ([#25110](hashicorp/terraform-provider-azurerm#25110 New Resource: `azurerm_workloads_sap_discovery_virtual_instance` ([#24342](hashicorp/terraform-provider-azurerm#24342 New Resource: `azurerm_redis_cache_policy` ([#25477](hashicorp/terraform-provider-azurerm#25477 New Resource: `azurerm_redis_cache_policy_assignment` ([#25477](https://github.com/hashicorp/terraform-provider-azurerm/issues/25477))

ENHANCEMENTS:

* dependencies: updating to `v0.20240402.1085733` of `github.com/hashicorp/go-azure-sdk` ([#25482](hashicorp/terraform-provider-azurerm#25482 dependencies: updating to `v0.67.0` of `github.com/hashicorp/go-azure-helpers` ([#25446](hashicorp/terraform-provider-azurerm#25446 dependencies: updating to `v0.25.4` of `github.com/tombuildsstuff/giovanni` ([#25404](hashicorp/terraform-provider-azurerm#25404 `alertsmanagement` - updating remaining resources to use `hashicorp/go-azure-sdk` ([#25486](hashicorp/terraform-provider-azurerm#25486 `applicationinsights` - updating remaining resources to use `hashicorp/go-azure-sdk` ([#25376](hashicorp/terraform-provider-azurerm#25376 `compute` - update to API version `2024-03-01` ([#25436](hashicorp/terraform-provider-azurerm#25436 `compute` - update shared image resources and data sources to use `hashicorp/go-azure-sdk` ([#25503](hashicorp/terraform-provider-azurerm#25503 `containerinstance` - update to use the transport layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#25416](hashicorp/terraform-provider-azurerm#25416 `maintenance` - updating to API Version `2023-04-01` ([#25388](hashicorp/terraform-provider-azurerm#25388 `recovery_services` - Add `recovery_service` block to the provider that supports `vm_backup_stop_protection_and_retain_data_on_destroy` and `purge_protected_items_from_vault_on_destroy`([#25515](hashicorp/terraform-provider-azurerm#25515 `storage` - the Storage Account cache is now populated using `hashicorp/go-azure-sdk` ([#25437](hashicorp/terraform-provider-azurerm#25437 `azurerm_bot_service_azure_bot` - support for the `cmk_key_vault_key_url` property ([#23640](hashicorp/terraform-provider-azurerm#23640 `azurerm_capacity_reservation` - update validation for `capacity` ([#25471](hashicorp/terraform-provider-azurerm#25471 `azurerm_container_app` - add support for `key_vault_id` and `identity` properties in the `secret` block ([#24773](hashicorp/terraform-provider-azurerm#24773 `azurerm_databricks_workspace` - expose `managed_services_cmk_key_vault_id` and `managed_disk_cmk_key_vault_id and key_vault_id` to support cross subscription CMK's. ([#25091](hashicorp/terraform-provider-azurerm#25091 `azurerm_databricks_workspace_root_dbfs_customer_managed_key` - expose `key_vault_id` to support cross subscription CMK's. ([#25091](hashicorp/terraform-provider-azurerm#25091 `azurerm_managed_hsm_role_*_ids` - use specific resource id to replace generic nested item id ([#25323](hashicorp/terraform-provider-azurerm#25323 `azurerm_mssql_database` - add support for `secondary_type` ([#25360](hashicorp/terraform-provider-azurerm#25360 `azurerm_monitor_scheduled_query_rules_alert_v2` - support for the `identity` block ([#25365](hashicorp/terraform-provider-azurerm#25365 `azurerm_mssql_server_extended_auditing_policy` - support for `audit_actions_and_groups` and `predicate_expression` ([#25425](hashicorp/terraform-provider-azurerm#25425 `azurerm_netapp_account` - can now be imported ([#25384](hashicorp/terraform-provider-azurerm#25384 `azurerm_netapp_volume` - support for the `kerberos_enabled`, `smb_continuous_availability_enabled`, `kerberos_5_read_only_enabled`, `kerberos_5_read_write_enabled`, `kerberos_5i_read_only_enabled`, `kerberos_5i_read_write_enabled`, `kerberos_5p_read_only_enabled`, and `kerberos_5p_read_write_enabled` properties ([#25385](hashicorp/terraform-provider-azurerm#25385 `azurerm_recovery_services_vault` - upgrading to version `2024-01-01` ([#25325](hashicorp/terraform-provider-azurerm#25325 `azurerm_stack_hci_cluster` - the `client_id` property is now optional ([#25407](hashicorp/terraform-provider-azurerm#25407 `azurerm_storage_encryption_scope` - refactoring to use `hashicorp/go-azure-sdk` rather than `Azure/azure-sdk-for-go` ([#25437](hashicorp/terraform-provider-azurerm#25437 `azurerm_mssql_elasticpool` - the `maintenance_configuration_name` property now supports values `SQL_SouthAfricaNorth_DB_1`, `SQL_SouthAfricaNorth_DB_2`, `SQL_WestUS3_DB_1` and `SQL_WestUS3_DB_2` ([#25500](hashicorp/terraform-provider-azurerm#25500 `azurerm_lighthouse_assignment` - updating API Version from `2019-06-01` to `2022-10-01` ([#25473](https://github.com/hashicorp/terraform-provider-azurerm/issues/25473))

BUG FIXES:

* `network` - updating the `GatewaySubnet` validation to show the Subnet Name when the validation fails ([#25484](hashicorp/terraform-provider-azurerm#25484 `azurerm_function_app_hybrid_connection` - fix an issue during creation when `send_key_name` is specified ([#25379](hashicorp/terraform-provider-azurerm#25379 `azurerm_linux_web_app_slot` - fix a crash when upgrading the provider to v3.88.0 or later ([#25406](hashicorp/terraform-provider-azurerm#25406 `azurerm_mssql_database` - update the behavior of the `enclave_type` field. ([#25508](hashicorp/terraform-provider-azurerm#25508 `azurerm_mssql_elasticpool` - update the behavior of the `enclave_type` field. ([#25508](hashicorp/terraform-provider-azurerm#25508 `azurerm_network_manager_deployment` - add locking ([#25368](hashicorp/terraform-provider-azurerm#25368 `azurerm_resource_group_template_deployment` - changes to `parameters_content` and `template_content` now force `output_content` to be updated in the plan ([#25403](hashicorp/terraform-provider-azurerm#25403 `azurerm_storage_blob` - fix a potential crash when the endpoint is unreachable ([#25404](hashicorp/terraform-provider-azurerm#25404 `azurerm_storage_container` - fix a potential crash when the endpoint is unreachable ([#25404](hashicorp/terraform-provider-azurerm#25404 `azurerm_storage_data_lake_gen2_filesystem` - fix a potential crash when the endpoint is unreachable ([#25404](hashicorp/terraform-provider-azurerm#25404 `azurerm_storage_data_lake_gen2_filesystem_path` - fix a potential crash when the endpoint is unreachable ([#25404](hashicorp/terraform-provider-azurerm#25404 `azurerm_storage_queue` - fix a potential crash when the endpoint is unreachable ([#25404](hashicorp/terraform-provider-azurerm#25404 `azurerm_storage_share` - fix a potential crash when the endpoint is unreachable ([#25404](hashicorp/terraform-provider-azurerm#25404 `azurerm_storage_share_directory` - fix a potential crash when the endpoint is unreachable ([#25404](hashicorp/terraform-provider-azurerm#25404 `azurerm_storage_share_directory` - resolve an issue where directories might fail to destroy ([#25404](hashicorp/terraform-provider-azurerm#25404 `azurerm_storage_share_file` - fix a potential crash when the endpoint is unreachable ([#25404](hashicorp/terraform-provider-azurerm#25404 `azurerm_storage_share_file` - fix several bugs with path handling when creating files in subdirectories ([#25404](hashicorp/terraform-provider-azurerm#25404 `azurerm_web_app_hybrid_connection` - fix an issue during creation when `send_key_name` is specified ([#25379](hashicorp/terraform-provider-azurerm#25379 `azurerm_windows_web_app` - prevent a panic during resource upgrade ([#25509](https://github.com/hashicorp/terraform-provider-azurerm/issues/25509))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/88/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>

github-actions · 2024-05-04T02:03:10Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

New Resource: azurerm_workloads_sap_discovery_virtual_instance

60a371c

github-actions bot added documentation dependencies size/XL labels Dec 27, 2023

neil-yechenwei marked this pull request as draft December 27, 2023 08:56

ms-zhenhua suggested changes Dec 29, 2023

View reviewed changes

github-actions bot added the waiting-response label Dec 29, 2023

update code

6465946

github-actions bot removed the waiting-response label Jan 3, 2024

update code

6dc9bd9

neil-yechenwei requested a review from ms-zhenhua January 4, 2024 08:14

ms-zhenhua approved these changes Jan 17, 2024

View reviewed changes

neil-yechenwei marked this pull request as ready for review January 17, 2024 10:37

update code

3a19ed2

update code

b85135d

jackofallops requested a review from tombuildsstuff January 29, 2024 11:10

neil-yechenwei added 2 commits February 2, 2024 10:08

update code

953c962

update code

3304853

katbyte assigned catriona-m Feb 19, 2024

update code

fa0da52

catriona-m requested changes Mar 5, 2024

View reviewed changes

catriona-m added the waiting-response label Mar 5, 2024

update code

a8d2869

github-actions bot removed the waiting-response label Mar 6, 2024

neil-yechenwei added 2 commits March 6, 2024 14:25

update code

235580a

update code

a08f065

catriona-m added the waiting-response label Mar 7, 2024

update code

4c220a0

github-actions bot removed the waiting-response label Mar 8, 2024

update code

9febdff

update code

2ec7f5e

catriona-m added waiting-response upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Mar 19, 2024

update code

af5e6ab

github-actions bot removed the waiting-response label Mar 27, 2024

update code

5fa0cca

github-actions bot added the waiting-response label Mar 27, 2024

update code

1bb103c

github-actions bot removed the waiting-response label Mar 27, 2024

neil-yechenwei requested a review from catriona-m March 27, 2024 12:33

catriona-m requested changes Apr 2, 2024

View reviewed changes

github-actions bot added the waiting-response label Apr 2, 2024

neil-yechenwei requested a review from catriona-m April 3, 2024 06:51

github-actions bot removed the waiting-response label Apr 3, 2024

update code

6ef7745

catriona-m approved these changes Apr 3, 2024

View reviewed changes

catriona-m merged commit 4505ac1 into hashicorp:main Apr 3, 2024
33 checks passed

github-actions bot added this to the v3.98.0 milestone Apr 3, 2024

catriona-m added a commit that referenced this pull request Apr 3, 2024

Update CHANGELOG.md #24342

dfa96b5

github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_workloads_sap_discovery_virtual_instance` #24342

New Resource: `azurerm_workloads_sap_discovery_virtual_instance` #24342

neil-yechenwei commented Dec 27, 2023

ms-zhenhua left a comment

neil-yechenwei commented Jan 4, 2024

ms-zhenhua commented Jan 17, 2024

tombuildsstuff commented Jan 25, 2024

neil-yechenwei commented Jan 26, 2024

catriona-m left a comment

catriona-m Mar 5, 2024

neil-yechenwei Mar 6, 2024

neil-yechenwei commented Mar 8, 2024

neil-yechenwei commented Mar 27, 2024 •

edited

Loading

neil-yechenwei commented Apr 2, 2024

catriona-m left a comment

catriona-m Apr 2, 2024

neil-yechenwei Apr 3, 2024

catriona-m Apr 2, 2024

neil-yechenwei Apr 3, 2024

neil-yechenwei commented Apr 3, 2024

catriona-m left a comment

github-actions bot commented May 4, 2024


		* `type` - (Required) The type of Managed Service Identity that should be configured on this SAP Discovery Virtual Instance. Only possible value is `UserAssigned`.

	managed_resource_group_name = "managedTestRG%d"
	managed_resource_group_name = "acctestmanagedRG%d"

New Resource: azurerm_workloads_sap_discovery_virtual_instance #24342

New Resource: azurerm_workloads_sap_discovery_virtual_instance #24342

Conversation

neil-yechenwei commented Dec 27, 2023

ms-zhenhua left a comment

Choose a reason for hiding this comment

neil-yechenwei commented Jan 4, 2024

ms-zhenhua commented Jan 17, 2024

tombuildsstuff commented Jan 25, 2024

neil-yechenwei commented Jan 26, 2024

catriona-m left a comment

Choose a reason for hiding this comment

catriona-m Mar 5, 2024

Choose a reason for hiding this comment

neil-yechenwei Mar 6, 2024

Choose a reason for hiding this comment

neil-yechenwei commented Mar 8, 2024

neil-yechenwei commented Mar 27, 2024 • edited Loading

neil-yechenwei commented Apr 2, 2024

catriona-m left a comment

Choose a reason for hiding this comment

catriona-m Apr 2, 2024

Choose a reason for hiding this comment

neil-yechenwei Apr 3, 2024

Choose a reason for hiding this comment

catriona-m Apr 2, 2024

Choose a reason for hiding this comment

neil-yechenwei Apr 3, 2024

Choose a reason for hiding this comment

neil-yechenwei commented Apr 3, 2024

catriona-m left a comment

Choose a reason for hiding this comment

github-actions bot commented May 4, 2024

New Resource: `azurerm_workloads_sap_discovery_virtual_instance` #24342

New Resource: `azurerm_workloads_sap_discovery_virtual_instance` #24342

neil-yechenwei commented Mar 27, 2024 •

edited

Loading