Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature flagged schema fixes #23024

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Conversation

jackofallops
Copy link
Member

fixes several schema issues behind the fourpointoh feature flag

* resource azurerm_kusto_cluster: ConflictsWith: language_extensions cannot
        reference self (language_extensions)
* resource azurerm_consumption_budget_subscription: AtLeastOneOf: dimension
        references unknown attribute (filter.0.not) at part (not)
* resource azurerm_consumption_budget_management_group: AtLeastOneOf:
        dimension references unknown attribute (filter.0.not) at part (not)
* resource azurerm_windows_web_app: AtLeastOneOf: dotnet_core_version
        references unknown attribute
        (site_config.0.application_stack.0.python_version) at part (python_version)
* resource azurerm_windows_web_app_slot: AtLeastOneOf: node_version
        references unknown attribute
        (site_config.0.application_stack.0.python_version) at part (python_version)
* resource azurerm_monitor_diagnostic_setting: ConflictsWith: enabled_log
        references unknown attribute (log) at part (log)
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackofallops LGTM 🦝

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jackofallops jackofallops merged commit 601e35c into main Aug 21, 2023
@jackofallops jackofallops deleted the b/fourpointoh-featureflag-schma-bugs branch August 21, 2023 09:53
@github-actions github-actions bot added this to the v3.71.0 milestone Aug 21, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants