New Resource: `azurerm_site_recovery_vmware_replicated_vm` #22477

ziyeqf · 2023-07-12T04:59:51Z

The test requires a vault and a physical connected to it (appliance installed) to run.

Test

TF_ACC=1 go test -v ./internal/services/recoveryservices -run="TestAccSiteVMWareRecoveryReplicatedVM_basic" -timeout=720m
=== RUN   TestAccSiteVMWareRecoveryReplicatedVM_basic
=== PAUSE TestAccSiteVMWareRecoveryReplicatedVM_basic
=== CONT  TestAccSiteVMWareRecoveryReplicatedVM_basic
--- PASS: TestAccSiteVMWareRecoveryReplicatedVM_basic (5114.44s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      5114.453s

And I want to explain why there are some deafult_xxx properties:
For example, log_storage_account_id is a property of a manged_disk, but managed_disk could only be specified when the mobility service is already installed on the source vm, while the mobility service is installed in creation of this resource. So, it's impossible to specify manged_disk.log_storage_account_id on the first creation, then a default_log_storage_account_id is exposed and the value will be applied to all managed_disks.

magodo

Thanks for this PR!
I've taken a look through and left some comments inline. Once they are resolved, we can take another look 👍

website/docs/r/site_recovery_vmware_replicated_vm.html.markdown

internal/services/recoveryservices/site_recovery_vmware_replicated_vm_resource.go

Signed-off-by: ziyeqf <[email protected]>

ziyeqf · 2023-07-18T11:08:23Z

tftest recoveryservices TestAccSiteVMWareRecoveryReplicatedVM_basic
=== RUN   TestAccSiteVMWareRecoveryReplicatedVM_basic
=== PAUSE TestAccSiteVMWareRecoveryReplicatedVM_basic
=== CONT  TestAccSiteVMWareRecoveryReplicatedVM_basic
--- PASS: TestAccSiteVMWareRecoveryReplicatedVM_basic (5019.28s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      5019.341s

Signed-off-by: ziyeqf <[email protected]>

tombuildsstuff · 2023-12-07T16:32:45Z

@magodo looks like this one's waiting for a re-review - would you mind taking another look at this one?

website/docs/r/site_recovery_vmware_replicated_vm.html.markdown

internal/services/recoveryservices/custompollers/vmware_replicated_vm_poller.go

internal/services/recoveryservices/site_recovery_vmware_replicated_vm_resource_test.go

internal/services/recoveryservices/site_recovery_vmware_replicated_vm_resource.go

website/docs/r/site_recovery_vmware_replicated_vm.html.markdown

magodo · 2023-12-08T09:26:50Z

website/docs/r/site_recovery_vmware_replicated_vm.html.markdown

+
+* `managed_disk` - (Optional) One or more `managed_disk` block as defined below. It's available only if mobility service is already installed on the source VM.
+
+**Note:** a replicated VM could be created without `managed_disk` block, once the block has been specified, changing it expect removing it forces a new resource to be created..


Can we just remove this line and add the "Changing this forces a new resource to be created" in above line?

But it allows being removed .

magodo · 2023-12-08T09:34:05Z

@ziyeqf I've reviewed the latest state and left some comments. Meanwhile, I've noticed some of the previous comments are not resolved. Once they are resolved, we can take another look!

magodo · 2023-12-20T02:08:22Z

LGTM 👍

katbyte

LGTM 💾

katbyte

LGTM 💾

…#22477) * New Resource: `azurerm_site_recovery_vmware_replicated_vm` Signed-off-by: ziyeqf <[email protected]> * update test case Signed-off-by: ziyeqf <[email protected]> * update `physical_server_credential_name` Signed-off-by: ziyeqf <[email protected]> * refresh /vendor Signed-off-by: ziyeqf <[email protected]> * website typo Signed-off-by: ziyeqf <[email protected]> * golint Signed-off-by: ziyeqf <[email protected]> * update per comments Signed-off-by: ziyeqf <[email protected]> * add comments Signed-off-by: ziyeqf <[email protected]> * replace `utils.String` to `pointer.To` Signed-off-by: ziyeqf <[email protected]> * schema lint Signed-off-by: ziyeqf <[email protected]> * update test case Signed-off-by: ziyeqf <[email protected]> * refresh vendor Signed-off-by: ziyeqf <[email protected]> * update code Signed-off-by: ziyeqf <[email protected]> * refresh vendor * update per comment --------- Signed-off-by: ziyeqf <[email protected]>

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.89.0" to "3.90.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.90.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.90.0
UPGRADE NOTES:

* provider - The provider will now automatically register the `AppConfiguration`, `DataFactory`, and `SignalRService` Resource Providers. When running Terraform with limited permissions, note that you [must disable automatic Resource Provider Registration and ensure that any Resource Providers Terraform requires are registered]([XXX](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs#skip_provider_registration)). ([#24645](hashicorp/terraform-provider-azurerm#24645; 
FEATURES:

* **New Data Source**: `azurerm_nginx_configuration` ([#24642](hashicorp/terraform-provider-azurerm#24642 **New Data Source**: `azurerm_virtual_desktop_workspace` ([#24732](hashicorp/terraform-provider-azurerm#24732 **New Resource**: `azurerm_kubernetes_fleet_update_strategy` ([#24328](hashicorp/terraform-provider-azurerm#24328 **New Resource**: `azurerm_site_recovery_vmware_replicated_vm` ([#22477](hashicorp/terraform-provider-azurerm#22477 **New Resource**: `azurerm_spring_cloud_new_relic_application_performance_monitoring` ([#24699](https://github.com/hashicorp/terraform-provider-azurerm/issues/24699))

ENHANCEMENTS:

* provider: registering the Resource Provider `Microsoft.AppConfiguration` ([#24645](hashicorp/terraform-provider-azurerm#24645 provider: registering the Resource Provider `Microsoft.DataFactory` ([#24645](hashicorp/terraform-provider-azurerm#24645 provider: registering the Resource Provider `Microsoft.SignalRService` ([#24645](hashicorp/terraform-provider-azurerm#24645 provider: the Provider is now built using Go 1.21.6 ([#24653](hashicorp/terraform-provider-azurerm#24653 dependencies: the dependency `github.com/hashicorp/go-azure-sdk` has been split into multiple Go Modules - and as such will be referred to by those paths going forwards ([#24636](hashicorp/terraform-provider-azurerm#24636 dependencies: updating to ``v0.20240201.1064937` of `github.com/hashicorp/go-azure-sdk/resource-manager` ([#24738](hashicorp/terraform-provider-azurerm#24738 dependencies: updating to `v0.20240201.1064937` of `github.com/hashicorp/go-azure-sdk/sdk` ([#24738](hashicorp/terraform-provider-azurerm#24738 `appservice`: update to `go-azure-sdk` and API version `2023-01-01` ([#24688](hashicorp/terraform-provider-azurerm#24688 `datafactory`: updating to use `tombuildsstuff/kermit` ([#24675](hashicorp/terraform-provider-azurerm#24675 `hdinsight`: refactoring to use `github.com/hashicorp/go-azure-sdk/resource-manager` ([#24011](hashicorp/terraform-provider-azurerm#24011 `hdinsight`: updating to API Version `2021-06-01` ([#24011](hashicorp/terraform-provider-azurerm#24011 `loadbalancer`: updating to use `hashicorp/go-azure-sdk` ([#24291](hashicorp/terraform-provider-azurerm#24291 `nginx`: updating to API Version `2023-09-01` ([#24640](hashicorp/terraform-provider-azurerm#24640 `servicefabricmanagedcluster`: updating to use the base layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#24654](hashicorp/terraform-provider-azurerm#24654 `springcloud`: updating to use API Version `2023-11-01-preview` ([#24690](hashicorp/terraform-provider-azurerm#24690 `subscriptions`: refactoring to use `hashicorp/go-azure-sdk` ([#24663](hashicorp/terraform-provider-azurerm#24663 Data Source: `azurerm_stream_analytics_job` - support for User Assigned Identities ([#24738](hashicorp/terraform-provider-azurerm#24738 `azurerm_cosmosdb_account` - support for the `gremlin_database` and `tables_to_restore` properties ([#24627](hashicorp/terraform-provider-azurerm#24627 `azurerm_bot_channel_email` - support for the `magic_code` property ([#23129](hashicorp/terraform-provider-azurerm#23129 `azurerm_cosmosdb_account` - support for the `partition_merge_enabled` property ([#24615](hashicorp/terraform-provider-azurerm#24615 `azurerm_mssql_managed_database` - support for the `immutable_backups_enabled` property ([#24745](hashicorp/terraform-provider-azurerm#24745 `azurerm_mssql_database` - support for the `immutable_backups_enabled` property ([#24745](hashicorp/terraform-provider-azurerm#24745 `azurerm_palo_alto_next_generation_firewall_virtual_hub_panorama` - support for the `trusted_address_ranges` property ([#24459](hashicorp/terraform-provider-azurerm#24459 `azurerm_palo_alto_next_generation_firewall_virtual_network_local_rulestack` - support for the `trusted_address_ranges` property ([#24459](hashicorp/terraform-provider-azurerm#24459 `azurerm_palo_alto_next_generation_firewall_virtual_network_panorama` - support for the `trusted_address_ranges` property ([#24459](hashicorp/terraform-provider-azurerm#24459 `azurerm_servicebus_namespace` - updating to use API Version `2022-10-01-preview` ([#24650](hashicorp/terraform-provider-azurerm#24650 `azurerm_spring_cloud_api_portal` - support for the `api_try_out_enabled` property ([#24696](hashicorp/terraform-provider-azurerm#24696 `azurerm_spring_cloud_gateway` - support for the `local_response_cache_per_route` and `local_response_cache_per_instance` properties ([#24697](hashicorp/terraform-provider-azurerm#24697 `azurerm_stream_analytics_job` - support for User Assigned Identities ([#24738](hashicorp/terraform-provider-azurerm#24738 `azurerm_subscription` - refactoring to use `hashicorp/go-azure-sdk` to set tags on the subscription ([#24734](hashicorp/terraform-provider-azurerm#24734 `azurerm_virtual_desktop_workspace` - correctly validate the `name` property ([#24668](https://github.com/hashicorp/terraform-provider-azurerm/issues/24668))


BUG FIXES:

* provider: skip registration for resource providers that are unavailable ([#24571](hashicorp/terraform-provider-azurerm#24571 `azurerm_app_configuration` - no longer require `lifecycle_ignore_changes` for the `value` property when using a key vault reference ([#24702](hashicorp/terraform-provider-azurerm#24702 `azurerm_app_service_managed_certificate` - fix casing issue in `app_service_plan_id` by parsing insensitively ([#24664](hashicorp/terraform-provider-azurerm#24664 `azurerm_cognitive_deployment` - updates now include the `version` property ([#24700](hashicorp/terraform-provider-azurerm#24700 `azurerm_dns_cname_record` - prevent casing issue in `target_resource_id` by parsing the ID insensitively ([#24181](hashicorp/terraform-provider-azurerm#24181 `azurerm_mssql_managed_instance_failover_group` - prevent an issue when trying to create a failover group with a managed instance from a different subscription ([#24646](hashicorp/terraform-provider-azurerm#24646 `azurerm_storage_account` - conditionally update properties only when needed ([#24669](hashicorp/terraform-provider-azurerm#24669 `azurerm_storage_account` - change update order for `access_tier`to prevent errors when uploading blobs to the archive tier ([#22250](https://github.com/hashicorp/terraform-provider-azurerm/issues/22250))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/1075/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>

github-actions · 2024-04-26T02:08:58Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added documentation dependencies service/recovery-services size/XL labels Jul 12, 2023

magodo requested changes Jul 17, 2023

View reviewed changes

github-actions bot added waiting-response and removed waiting-response labels Jul 17, 2023

ziyeqf added 10 commits July 18, 2023 10:19

New Resource: azurerm_site_recovery_vmware_replicated_vm

f56f925

Signed-off-by: ziyeqf <[email protected]>

update test case

9de39a4

Signed-off-by: ziyeqf <[email protected]>

update physical_server_credential_name

b531456

Signed-off-by: ziyeqf <[email protected]>

refresh /vendor

6574b3a

Signed-off-by: ziyeqf <[email protected]>

website typo

5285a62

Signed-off-by: ziyeqf <[email protected]>

golint

0736548

Signed-off-by: ziyeqf <[email protected]>

update per comments

0632f64

Signed-off-by: ziyeqf <[email protected]>

add comments

a4d5917

Signed-off-by: ziyeqf <[email protected]>

replace utils.String to pointer.To

50d0d37

Signed-off-by: ziyeqf <[email protected]>

schema lint

66daad3

Signed-off-by: ziyeqf <[email protected]>

ziyeqf force-pushed the tengzh/recovery/vmware/replicated_vm branch from 60368e7 to 66daad3 Compare July 18, 2023 02:19

github-actions bot added waiting-response and removed waiting-response labels Jul 18, 2023

update test case

3efd513

Signed-off-by: ziyeqf <[email protected]>

github-actions bot removed the waiting-response label Jul 18, 2023

ziyeqf added 3 commits August 14, 2023 13:32

Merge branch 'main' into tengzh/recovery/vmware/replicated_vm

1f8e10c

refresh vendor

1b50182

Signed-off-by: ziyeqf <[email protected]>

update code

4770902

Signed-off-by: ziyeqf <[email protected]>

tombuildsstuff requested a review from magodo December 7, 2023 16:32

tombuildsstuff assigned magodo Dec 7, 2023

magodo requested changes Dec 8, 2023

View reviewed changes

github-actions bot added the waiting-response label Dec 8, 2023

ziyeqf added 3 commits December 11, 2023 16:05

Merge branch 'main' into tengzh/recovery/vmware/replicated_vm

7f0fc67

refresh vendor

1cb8301

update per comment

20227c2

github-actions bot removed the waiting-response label Dec 19, 2023

ziyeqf requested a review from magodo December 19, 2023 09:03

katbyte approved these changes Jan 30, 2024

View reviewed changes

katbyte merged commit e5e201f into hashicorp:main Jan 30, 2024
29 of 30 checks passed

github-actions bot added this to the v3.90.0 milestone Jan 30, 2024

katbyte added a commit that referenced this pull request Jan 30, 2024

Update CHANGELOG.md #22477

c66f804

rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this pull request Jan 30, 2024

Update CHANGELOG.md hashicorp#22477

b15cad1

github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_site_recovery_vmware_replicated_vm` #22477

New Resource: `azurerm_site_recovery_vmware_replicated_vm` #22477

ziyeqf commented Jul 12, 2023 •

edited

Loading

magodo left a comment

ziyeqf commented Jul 18, 2023 •

edited

Loading

tombuildsstuff commented Dec 7, 2023

magodo Dec 8, 2023

ziyeqf Dec 19, 2023

magodo commented Dec 8, 2023

magodo commented Dec 20, 2023

katbyte left a comment

katbyte left a comment

github-actions bot commented Apr 26, 2024


		* `managed_disk` - (Optional) One or more `managed_disk` block as defined below. It's available only if mobility service is already installed on the source VM.

		Note: a replicated VM could be created without `managed_disk` block, once the block has been specified, changing it expect removing it forces a new resource to be created..

New Resource: azurerm_site_recovery_vmware_replicated_vm #22477

New Resource: azurerm_site_recovery_vmware_replicated_vm #22477

Conversation

ziyeqf commented Jul 12, 2023 • edited Loading

Test

magodo left a comment

Choose a reason for hiding this comment

ziyeqf commented Jul 18, 2023 • edited Loading

tombuildsstuff commented Dec 7, 2023

magodo Dec 8, 2023

Choose a reason for hiding this comment

ziyeqf Dec 19, 2023

Choose a reason for hiding this comment

magodo commented Dec 8, 2023

magodo commented Dec 20, 2023

katbyte left a comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 26, 2024

New Resource: `azurerm_site_recovery_vmware_replicated_vm` #22477

New Resource: `azurerm_site_recovery_vmware_replicated_vm` #22477

ziyeqf commented Jul 12, 2023 •

edited

Loading

ziyeqf commented Jul 18, 2023 •

edited

Loading