Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle gone gracefully in read for azurerm_mssql_server_dns_alias #18619

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

turkenh
Copy link
Contributor

@turkenh turkenh commented Oct 3, 2022

This PR handles manual resource deletion gracefully for azurerm_mssql_server_dns_alias resource as mentioned here:

https://learn.hashicorp.com/tutorials/terraform/provider-setup#implement-read

When you create something in Terraform but delete it manually, Terraform should gracefully handle it. If the API returns an error when the resource doesn't exist, the read function should check to see if the resource is available first. If the resource isn't available, the function should set the ID to an empty string so Terraform "destroys" the resource in state. The following code snippet is an example of how this can be implemented; you do not need to add this to your configuration for this tutorial.

Fixes #18614

@github-actions github-actions bot added the service/mssql Microsoft SQL Server label Oct 3, 2022
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenh - LGTM 🌵

@katbyte katbyte merged commit b108d0d into hashicorp:main Oct 3, 2022
@github-actions github-actions bot added this to the v3.26.0 milestone Oct 3, 2022
@github-actions
Copy link

This functionality has been released in v3.26.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/mssql Microsoft SQL Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_mssql_server_dns_alias plan fails if resource deleted manually
2 participants