Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ACI API version to 2021-10-01 #17837

Closed
wants to merge 2 commits into from

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Aug 2, 2022

This PR updates ACI API version to 2021-10-01.

There is a breaking change in this update: the network profile was removed beginning in API version 2021-07-01 and is a breaking change. With the newer API versions, customers can now specify their subnet ID directly instead of creating the network profile as an intermediary for holding the subnet ID. The new usage satisfies VNET consistency requirements across Azure. This deprecation is also mentioned in the Azure document: https://docs.microsoft.com/en-us/azure/container-instances/container-instances-vnet.

In short, customers using network profiles can continue to use API version 2021-03-01 and below with full support for network profiles. For later versions, customers should use the new subnet ID property.

NOTE: Though the subnetIds is a list of subnetIds, while currently the service only support one subnetId.

Test

💤  TF_ACC=1 go test -v -timeout=20h ./internal/services/containers  -run='TestAccContainerGroup_virtualNetwork$|TestAccContainerGroup_UserAssignedIdentityWithVirtualNetwork$|TestAccContainerGroup_SystemAssignedIdentityVirtualNetwork$|TestAccContainerGroup_virtualNetworkParallel'
=== RUN   TestAccContainerGroup_UserAssignedIdentityWithVirtualNetwork
=== PAUSE TestAccContainerGroup_UserAssignedIdentityWithVirtualNetwork
=== RUN   TestAccContainerGroup_virtualNetwork
=== PAUSE TestAccContainerGroup_virtualNetwork
=== RUN   TestAccContainerGroup_virtualNetworkParallel
=== PAUSE TestAccContainerGroup_virtualNetworkParallel
=== RUN   TestAccContainerGroup_SystemAssignedIdentityVirtualNetwork
=== PAUSE TestAccContainerGroup_SystemAssignedIdentityVirtualNetwork
=== CONT  TestAccContainerGroup_UserAssignedIdentityWithVirtualNetwork
=== CONT  TestAccContainerGroup_virtualNetworkParallel
=== CONT  TestAccContainerGroup_SystemAssignedIdentityVirtualNetwork
=== CONT  TestAccContainerGroup_virtualNetwork
--- PASS: TestAccContainerGroup_virtualNetwork (248.54s)
--- PASS: TestAccContainerGroup_SystemAssignedIdentityVirtualNetwork (335.74s)
--- PASS: TestAccContainerGroup_virtualNetworkParallel (542.01s)
--- PASS: TestAccContainerGroup_UserAssignedIdentityWithVirtualNetwork (1705.13s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/containers    1705.147s

@magodo magodo marked this pull request as ready for review August 3, 2022 02:02
@dkuzmenok
Copy link
Contributor

@magodo I've had a PR to cover ACI upgrade (#17785). I guess this PR would be preferred, so it would be great if you could include new fields, added in later API versions.

@magodo
Copy link
Collaborator Author

magodo commented Aug 3, 2022

@dkuzmenok Oh, didn't notice that. My plan was to upgrade the API version first, then add up the new properties.

@magodo
Copy link
Collaborator Author

magodo commented Aug 4, 2022

Close this in favor of #17785

@magodo magodo closed this Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Sep 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants