MSI: refactoring to use an Embedded SDK

azurerm/internal/services/msi/client/client.go

@@ -1,16 +1,16 @@
 package client
 
 import (
-	"github.com/Azure/azure-sdk-for-go/services/msi/mgmt/2018-11-30/msi"
 	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/common"
+	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/msi/sdk/managedidentity"
 )
 
 type Client struct {
-	UserAssignedIdentitiesClient *msi.UserAssignedIdentitiesClient
+	UserAssignedIdentitiesClient *managedidentity.ManagedIdentityClient
 }
 
 func NewClient(o *common.ClientOptions) *Client {
-	UserAssignedIdentitiesClient := msi.NewUserAssignedIdentitiesClientWithBaseURI(o.ResourceManagerEndpoint, o.SubscriptionId)
+	UserAssignedIdentitiesClient := managedidentity.NewManagedIdentityClientWithBaseURI(o.ResourceManagerEndpoint)
 	o.ConfigureClient(&UserAssignedIdentitiesClient.Client, o.ResourceManagerAuthorizer)
 
 	return &Client{

azurerm/internal/services/msi/parse/user_assigned_identity_id.go

@@ -0,0 +1,13 @@
+package parse
+
+import "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/msi/sdk/managedidentity"
+
+// these are here primarily to enable migration over
+
+func UserAssignedIdentityID(input string) (*managedidentity.UserAssignedIdentitiesId, error) {
+	return managedidentity.ParseUserAssignedIdentitiesID(input)
+}
+
+func UserAssignedIdentityIDInsensitively(input string) (*managedidentity.UserAssignedIdentitiesId, error) {
+	return managedidentity.ParseUserAssignedIdentitiesIDInsensitively(input)
+}

azurerm/internal/services/msi/sdk/managedidentity/client.go

@@ -0,0 +1,15 @@
+package managedidentity
+
+import "github.com/Azure/go-autorest/autorest"
+
+type ManagedIdentityClient struct {
+	Client  autorest.Client
+	baseUri string
+}
+
+func NewManagedIdentityClientWithBaseURI(endpoint string) ManagedIdentityClient {
+	return ManagedIdentityClient{
+		Client:  autorest.NewClientWithUserAgent(userAgent()),
+		baseUri: endpoint,
+	}
+}