Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Function Apps in Consumption Plans #981

Merged
merged 2 commits into from
Mar 15, 2018

Conversation

tombuildsstuff
Copy link
Contributor

After a PR yesterday to the Swagger repository - it appears this is possible without any extra code changes - as such this PR adds support for Function Apps in Consumption Plans

Fixes #960

Tests pass:
```
$ acctests azurerm TestAccAzureRMFunctionApp_consumptionPlan
=== RUN   TestAccAzureRMFunctionApp_consumptionPlan
--- PASS: TestAccAzureRMFunctionApp_consumptionPlan (126.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	126.083s
```
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff
Copy link
Contributor Author

App Service Plan tests pass:

screen shot 2018-03-15 at 08 10 13

@tombuildsstuff
Copy link
Contributor Author

Function app tests pass:

screen shot 2018-03-15 at 08 10 59

@tombuildsstuff tombuildsstuff merged commit 67b7480 into master Mar 15, 2018
@tombuildsstuff tombuildsstuff deleted the app-service-plan-consumption branch March 15, 2018 13:13
tombuildsstuff added a commit that referenced this pull request Mar 15, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Functions App in Consumption Plan
2 participants