Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go sdk version from v48.1.0 to latest one #9683

Closed
neil-yechenwei opened this issue Dec 4, 2020 · 6 comments · Fixed by #10042
Closed

Upgrade go sdk version from v48.1.0 to latest one #9683

neil-yechenwei opened this issue Dec 4, 2020 · 6 comments · Fixed by #10042
Assignees
Labels
question sdk/requires-upgrade This is dependent upon upgrading an SDK
Milestone

Comments

@neil-yechenwei
Copy link
Contributor

neil-yechenwei commented Dec 4, 2020

Could you help to upgrade go sdk package to latest one since some new properties require new go sdk package?

@tombuildsstuff tombuildsstuff added question sdk/requires-upgrade This is dependent upon upgrading an SDK labels Dec 4, 2020
@tombuildsstuff tombuildsstuff self-assigned this Dec 4, 2020
@tombuildsstuff
Copy link
Contributor

@neil-yechenwei due to the breaking changes in SDK v49 - and the larger changes currently on-going - it's likely this won't be upgraded for a couple of weeks to avoid conflicts.

Would you be able to provide a link to the Github issues tracking the features/use-cases being solved by upgrading here?

Thanks!

@tombuildsstuff tombuildsstuff added this to the v2.41.0 milestone Dec 4, 2020
@neil-yechenwei neil-yechenwei changed the title Upgrade go sdk version from v48.1.0 to v49.0.0 Upgrade go sdk version from v48.1.0 to latest one Dec 4, 2020
@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Dec 4, 2020

Sure.

  1. The ExpressionEvaluationOptions property in azurerm_resource_group_template_deployment requires new go sdk package.
  2. The EventGroupingSettings property in azurerm_sentinel_alert_rule_scheduled requires new go sdk package.
  3. The queryString property in azurerm_resource_group_template_deployment requires new go sdk package. This property currently isn't released to azure-sdk-for-go repo. Once it's released, terraform side also needs to upgrade go sdk package to involve this property.

@ghost ghost removed the waiting-response label Dec 4, 2020
@tombuildsstuff
Copy link
Contributor

@neil-yechenwei can we add Github issues to track the use-cases we're looking to solve by adding these new fields? Thanks!

@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Dec 7, 2020

Add github issue link #9722 for queryString property.
Add github issue link #9723 for ExpressionEvaluationOptions property.
Add github issue link #9725 for EventGroupingSettings.

@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question sdk/requires-upgrade This is dependent upon upgrading an SDK
Projects
None yet
3 participants