-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: azurerm_media_transform
#9663
New resource: azurerm_media_transform
#9663
Conversation
…form-provider-azurerm into azurerm_media_transform
…form-provider-azurerm into azurerm_media_transform
…form-provider-azurerm into azurerm_media_transform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcanizalez - I've given this review and left some comments inline. I the resource might be easier to use with a preset block per type? WDYT?
azurerm/internal/services/media/tests/transform_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/tests/transform_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/tests/transform_resource_test.go
Outdated
Show resolved
Hide resolved
Thanks @katbyte I applied your suggestion and I changed too presets to use one preset block for type. You can continue reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcanizalez - just one more set of comments about sets to resolve and this should be good to merge!
Co-authored-by: kt <[email protected]>
…form-provider-azurerm into azurerm_media_transform
…ez/terraform-provider-azurerm into azurerm_media_transform
Thanks @katbyte I already applied your suggestions. So you can continue reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcanizalez! this LGTM 👍
Tests look good 👍 |
This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.40.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Including the support for new resource azurerm_media_transform. This PR resolves #9610
Checked: