Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management_api_diagnostic: Add sampling_percentage argument #9321

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

sirlatrom
Copy link
Contributor

@sirlatrom sirlatrom commented Nov 13, 2020

Closes #9320.

Draft: Awaits Azure/azure-sdk-for-go#13604.

Git wise based on the source branch of #9169, which must be merged first.

@manicminer
Copy link
Contributor

@sirlatrom Looks like this is fixed in the current SDK version! Do you want to pick it up again?

@sirlatrom sirlatrom marked this pull request as ready for review January 20, 2021 13:41
@ghost ghost added size/M and removed size/XL labels Jan 20, 2021
Signed-off-by: Sune Keller <[email protected]>
@sirlatrom
Copy link
Contributor Author

sirlatrom commented Jan 20, 2021

@sirlatrom Looks like this is fixed in the current SDK version! Do you want to pick it up again?

@manicminer Thanks for keeping track of it! I've now simplified this PR after first messing it up a bit.

@ghost ghost removed the waiting-response label Jan 20, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sirlatrom - this LGTM 👍

@katbyte katbyte added this to the v2.44.0 milestone Jan 21, 2021
@katbyte katbyte merged commit 5b53b2f into hashicorp:master Jan 21, 2021
katbyte added a commit that referenced this pull request Jan 21, 2021
@sirlatrom sirlatrom deleted the fix-9320 branch January 21, 2021 06:55
@ghost
Copy link

ghost commented Jan 21, 2021

This has been released in version 2.44.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.44.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 20, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_api_management_api_diagnostic: Support for sampling_percentage
4 participants