-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AKS autoscale property for new_pod_scale_up #9291
Conversation
@dstrebel since you're adding this here, do you mind also adding the other September API flags? https://docs.microsoft.com/en-us/azure/aks/cluster-autoscaler#using-the-autoscaler-profile |
I noted that, at moment, creating with TF a nodepool with an auto_scaler_profile, new-pod-scale-up-delay can't be specified but it's not set to default value [10s]. It's set to 0s. |
@marcoboffi actually the default should be "0s" - i'll follow up on the doc update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dstrebel - LGTM 👍
azurerm/internal/services/containers/tests/kubernetes_cluster_scaling_resource_test.go
Outdated
Show resolved
Hide resolved
…scaling_resource_test.go
Pushed a commit to fix the outstanding comments and the tests look good 👍 |
This has been released in version 2.44.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.44.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Add AKS Autoscale property for new_pod_scale_up.
Fixes #9008