Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v5.0 dotnet_framework_version to app_service validation #9251

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Add v5.0 dotnet_framework_version to app_service validation #9251

merged 3 commits into from
Nov 11, 2020

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Nov 10, 2020

Fixes #9241

$ TF_ACC=1 go test -v ./azurerm/internal/services/web/tests -timeout=1000m -run TestAccAzureRMAppService_windowsDotNet5
=== RUN   TestAccAzureRMAppService_windowsDotNet5
=== PAUSE TestAccAzureRMAppService_windowsDotNet5
=== CONT  TestAccAzureRMAppService_windowsDotNet5
--- PASS: TestAccAzureRMAppService_windowsDotNet5 (147.85s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/web/tests	149.388s
$ TF_ACC=1 go test -v ./azurerm/internal/services/web/tests -timeout=1000m -run TestAccAzureRMAppService_windowsDotNetUpdate
=== RUN   TestAccAzureRMAppService_windowsDotNetUpdate
=== PAUSE TestAccAzureRMAppService_windowsDotNetUpdate
=== CONT  TestAccAzureRMAppService_windowsDotNetUpdate
--- PASS: TestAccAzureRMAppService_windowsDotNetUpdate (233.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/web/tests	234.396s

@ghost ghost added the size/XS label Nov 10, 2020
@ghost ghost added the documentation label Nov 10, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - LGTM 👍

@katbyte katbyte added this to the v2.36.0 milestone Nov 11, 2020
@katbyte katbyte merged commit cb3076c into hashicorp:master Nov 11, 2020
katbyte added a commit that referenced this pull request Nov 11, 2020
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 2.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for .NET 5 runtime in App Service
2 participants