-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for os_disk_image_size_gb to get the disk size of the image #8904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @harshavmb
Thanks for this PR - taking a look through this is looking good, if we can fix up the comments then this otherwise looks good to me 👍
Thanks!
azurerm/internal/services/compute/shared_image_version_data_source.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/shared_image_version_data_source.go
Outdated
Show resolved
Hide resolved
…orp's suggestion... Defaulting osDiskImageSize to 0
Hi @tombuildsstuff , Thanks for the review. I made suggested changes. Hope you are okay with these changes! Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this @harshavmb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this @harshavmb
This has been released in version 2.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.33.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Adding support for os_disk_image_size to get the disk size of the image