azurerm_backup_policy_vm support instant_restore_retention_days property

[Lucretius]

Resolves #8321

I've added validation to ensure the retention range is at least 1 (it is in days, and zero didn't seem to make sense as an input) but let me know if this is incorrect.

[katbyte]

Thanks for the PR @Lucretius - this lookgs good, but i am curious if the API will take 0 as a value?

Other then that question this is good to merge!

[katbyte]

Thanks @Lucretius - upon giving this a once more over i think instant_restore_retention_days is a bit more clear. As such i've pushed a change to update it and am running tests

LGTM 👍

[katbyte]

Looks like we have a test failure, details on the line causing it i think

[jackofallops]

Hi @Lucretius - I just re-ran the tests and we're still seeing the error above:

Error: Error creating/updating Azure Backup Protection Policy "acctest-201022083134290184" (Resource Group "acctestRG-backup-201022083134290184"): backup.ProtectionPoliciesClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="UserErrorInvalidRequestParameter" Message="Parameter InstantRpRetentionRangeInDays in request is invalid\r\nPlease provide correct value for parameter InstantRpRetentionRangeInDays"```

Apologies, I've not had chance to review, can you confirm your fix? 

[Lucretius]

@jackofallops I think I am going to have to close this PR, I cannot seem to figure out how to pass the correct value in here. I've tried leaving it out, specifying it as nil, providing a default (the value is apparently defaulted to 2). I've tried updating the backup SDK to the latest version in case it was an SDK bug - nothing seems to work, the same error shows up.

[jackofallops]

Hi @Lucretius - I've had a quick dig and found that the problem seems to have been there's a default in the service (2 in the region I tested, but I'm not convinced it will be guaranteed to be the same in all locations), so I've set the schema to Computed and tweaked the code around sending it. I have the tests running again as I type, and if they pass I think this is good to merge.

[jackofallops]

Acceptance tests passing:

Outdated

[manicminer]

@jackofallops LGTM

[ghost]

This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.34.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!