Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augmented Network Security Rules still not allowing lists #863

Closed
keeperpl opened this issue Feb 20, 2018 · 3 comments
Closed

Augmented Network Security Rules still not allowing lists #863

keeperpl opened this issue Feb 20, 2018 · 3 comments

Comments

@keeperpl
Copy link

Terraform Version

Terraform v0.11.3

  • provider.azurerm v1.1.2

Affected Resource(s)

azurerm_network_security_rule

Terraform Configuration Files

resource "azurerm_network_security_rule" "xxxxx" {
  name                        = "xxxxx"
  description                 = "xxxxx"
  network_security_group_name = "xxxxx"
  direction                   = "Inbound"
  access                      = "Allow"
  priority                    = "150"
  source_address_prefix       = "xx.xx.xx.xx/xx"
  source_port_range           = "*"
  destination_address_prefix  = "*"
  destination_port_range      = ["161","155","88-90"]
  protocol                    = "tcp"
  resource_group_name         = "${azurerm_resource_group.resource_group.name}"
}

Expected Behavior

An augmented network security group should be created as - if i understand correctly - the issue was already fixed with proper pull request.

Actual Behavior

terraform plan

Error:

azurerm_network_security_rule.xxxxx: destination_port_range must be a single value, not a list

Steps to Reproduce

plan/apply a rule with list of ports/addresses.

References

#659

#692

@tombuildsstuff tombuildsstuff added this to the 1.1.3 milestone Feb 20, 2018
@tombuildsstuff
Copy link
Contributor

hi @keeperpl

Thanks for opening this issue :)

Support for specifying the Destination Port Ranges as a List was added in #692 which was released in v1.1.2 of the Azure Provider (yesterday) - this is exposed as the destination_port_ranges field - which is distinct from the destination_port_range field since they're different data types (a List vs a String). Would you be able to take a look and see if that solves your issue?

Thanks!

@keeperpl
Copy link
Author

Yes, it's all working if used with "destination_port_ranges" :)
Thank you!

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants