-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: azurerm_ip_groups #8556
Conversation
bf9dc2a
to
1e83cac
Compare
1e83cac
to
baaf7cf
Compare
…ps and source_ip_groups for rules
baaf7cf
to
7b5221c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from one minor comments about resource group names LGTP 👍
azurerm/internal/services/network/tests/ip_group_resource_test.go
Outdated
Show resolved
Hide resolved
Hi, I see this PR is adding a data source as well as a resource but the changelog only mentions the data source |
@alexwilcox9 looks like this is an accidental omission. both the resource and data source should make it in the next release. Good catch, thanks! |
This has been released in version 2.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.30.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
azurerm_firewall_network_rule_collection
: support destination_ip_groups and source_ip_groups for rulesazurerm_firewall_nat_rule_collection
: support source_ip_groups for rulesazurerm_firewall_application_rule_collection
: support source_ip_groups for rulesazurerm_ip_groups
new resource and data sourceCloses: #7047