Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource/data source azurerm_storage_sync_group #8462

Merged
merged 3 commits into from
Sep 17, 2020

Conversation

yupwei68
Copy link
Contributor

Partial fix: #2315.

Extend: #7843

Totally there will be three resources:
azurerm_storage_sync
azurerm_storage_sync_group
azurerm_cloud_endpoint

=== RUN TestAccAzureRMStorageSyncGroup_basic
=== PAUSE TestAccAzureRMStorageSyncGroup_basic
=== CONT TestAccAzureRMStorageSyncGroup_basic
--- PASS: TestAccAzureRMStorageSyncGroup_basic (254.76s)
=== RUN TestAccAzureRMStorageSyncGroup_requiresImport
=== PAUSE TestAccAzureRMStorageSyncGroup_requiresImport
=== CONT TestAccAzureRMStorageSyncGroup_requiresImport
--- PASS: TestAccAzureRMStorageSyncGroup_requiresImport (265.42s)

=== RUN TestAccDataSourceAzureRMStorageSyncGroup_basic
=== PAUSE TestAccDataSourceAzureRMStorageSyncGroup_basic
=== CONT TestAccDataSourceAzureRMStorageSyncGroup_basic
--- PASS: TestAccDataSourceAzureRMStorageSyncGroup_basic (258.85s)

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v2.29.0 milestone Sep 17, 2020
@mbfrahry mbfrahry merged commit 2ad8be4 into hashicorp:master Sep 17, 2020
mbfrahry added a commit that referenced this pull request Sep 17, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 2.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.29.0"
}
# ... other configuration ...

@yupwei68 yupwei68 deleted the wyp-sync-group branch October 12, 2020 01:48
@ghost
Copy link

ghost commented Oct 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft.StorageSync/storageSyncServices
2 participants